Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No label on proteins unless name specified #230

Closed
cjmyers opened this issue Oct 31, 2022 · 3 comments
Closed

No label on proteins unless name specified #230

cjmyers opened this issue Oct 31, 2022 · 3 comments
Assignees
@shb0527
Labels
bug Something isn't working
Milestone
1.4

Comments

@cjmyers
Copy link
Contributor

cjmyers commented Oct 31, 2022

All identifiers should default to the displayId when the name is not specified. Right now proteins only show the name field.
@LukasBuecherl LukasBuecherl added the bug Something isn't working label Aug 21, 2023
@LukasBuecherl LukasBuecherl added this to the 1.3 milestone Aug 21, 2023
@cjmyers
Copy link
Contributor Author

cjmyers commented Sep 18, 2024

Should add a default name when you add a macromolecule or other type of non-DNA object

@cjmyers
Copy link
Contributor Author

cjmyers commented Sep 18, 2024

macromolecule = prot
no glyph assigned = nga
complex = comp
rna = rna
dna = dna
small molecule = chem

@cjmyers cjmyers mentioned this issue Sep 25, 2024
Merged
@cjmyers
Copy link
Contributor Author

cjmyers commented Sep 25, 2024

Closed by PR #327

@cjmyers cjmyers closed this as completed Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shb0527 shb0527

Labels
bug Something isn't working
Projects
SBOLCanvas
Status: Done
Milestone
1.4
Development

No branches or pull requests
3 participants
@cjmyers @LukasBuecherl @shb0527