Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in combinatorial enumeration #348

Open
geoffbaldwin opened this issue Nov 11, 2024 · 0 comments
Open

Error in combinatorial enumeration #348

geoffbaldwin opened this issue Nov 11, 2024 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@geoffbaldwin
Copy link

When doing an enumerate design the default or assigned ‘top-level’ Display IDs are not fully enumerated across the set. This leads to unexpected ‘ghost’ permutations to appear with the top-level Display ID. If the sequence is defined as a component first (e.g. RBS F1) and then a combinatorial design is added with components other than F1, then the enumeration still has constructs with F1 present, but they are not fully enumerated across the set. So, the ‘top level’ Display id component is being treated differently from the other combinatorial components. The ‘top level’ components are included as a single design variant, whereas the combinatorial designs are fully enumerated across all variants.
e.g.
with 2 RBS sequences that each have combinatorial designs:
RBS1 – Display id: P3
Combinatorial variants: H1, S3
RBS2 – Display id: P1
Combinatorial variants: A1, E1

Enumerated design output: the ‘top-level’ Design ID single variant is the 4th row. Only the combinatorial RBSs are fully enumerated to give the 4 expected combinations. If all 3 RBSs for each component were fully enumerated there would be 9 designs.

Pro_XdV5 S3 CDS_VRSi A1 CDS_cNXb
Pro_XdV5 H1 CDS_VRSi A1 CDS_cNXb
Pro_XdV5 S3 CDS_VRSi E1 CDS_cNXb
Pro_XdV5 P3 CDS_VRSi P1 CDS_cNXb
Pro_XdV5 H1 CDS_VRSi E1 CDS_cNXb

Even if the Design id isn’t specified as a part, an extra variant appears with the randomly assigned Display ids.
This is a problem since there is no scenario I can think of where this top level would be desired in addition to the enumerated combinatorial designs.
The fact that it is there means that it would have to be pulled out of the CSV file before progressing to build and it always appears in random positions.

@cjmyers cjmyers added the bug Something isn't working label Nov 11, 2024
@cjmyers cjmyers added this to the 1.4 milestone Nov 11, 2024
@cjmyers cjmyers modified the milestones: 1.4, 1.4.1 Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants