Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug messages yield TypeErrors #408

Open
tcmitchell opened this issue Sep 15, 2021 · 1 comment
Open

Debug messages yield TypeErrors #408

tcmitchell opened this issue Sep 15, 2021 · 1 comment

Comments

@tcmitchell
Copy link
Collaborator

Several unit tests failed with the following stack trace during the overnight builds. Why these unit tests went down this path is still a mystery. But they did, which means if a user sets VERBOSE to True they would see the same exception.

Either change these debug prints to handle the booleans, or remove them. And if they're going to get updated, consider changing them to logging statements instead of prints.

Traceback (most recent call last):
  File "/home/runner/work/pySBOL2/pySBOL2/test/test_identified.py", line 110, in test_name
    cd = d.componentDefinitions['http://examples.org/ComponentDefinition/AmeR/1']
  File "/home/runner/work/pySBOL2/pySBOL2/sbol2/property.py", line 641, in __getitem__
    return self.get_uri(rdflib.URIRef(id))
  File "/home/runner/work/pySBOL2/pySBOL2/sbol2/property.py", line 669, in get_uri
    print('SBOL compliant URIs are set to ' +
TypeError: can only concatenate str (not "bool") to str
@tcmitchell
Copy link
Collaborator Author

The build jobs succeeded when rerun so it remains a mystery how VERBOSE was set to True to trigger the exception in this issue. There were other exceptions relating to online services that were not available, so that might have triggered it.

If the online services (validator, SynBioHub) are down regularly for overnight builds we might want to change the build schedule to a different time. We could work with the owners of those services to understand what their maintenance schedule is to understand what time windows should be avoided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant