Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github action that runs unittest and linter #433

Open
manulera opened this issue Apr 11, 2024 · 1 comment
Open

Add github action that runs unittest and linter #433

manulera opened this issue Apr 11, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@manulera
Copy link
Member

Hello, I think it would be good to have a github action that runs the tests on PR or Push, and runs a linter. Happy to contribute this during Harmony. @jakebeal

Do you have a problem with using black as a linter?

@jakebeal
Copy link
Collaborator

We do have an action for push & PR, it had just switched itself to idle since nobody's done a push or PR for a couple of months. I've turned it on again.

For running a linter, we've found black to be too restrictive. I'd prefer to match pysbol3, which usees pycodestyle and pylint with the following configuration: https://github.com/SynBioDex/pySBOL3/blob/main/setup.cfg
Note that this might find a massive number of issues, since it hasn't been run recently, so we'll likely want to see how bad it is before deciding how to best proceed, in terms of time prioritization.

@jakebeal jakebeal added the enhancement New feature or request label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants