Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in ReferencedObject::__init__ #430

Open
manulera opened this issue Apr 11, 2024 · 2 comments · Fixed by #431 · May be fixed by #436
Open

Bug in ReferencedObject::__init__ #430

manulera opened this issue Apr 11, 2024 · 2 comments · Fixed by #431 · May be fixed by #436

Comments

@manulera
Copy link
Member

Hello, I think there is an error in ReferencedObject::__init__. I found it like this:

import sbol2

participation = sbol2.Participation('p', participant='p1')
print(sbol2.ReferencedObject(participation, 'aa','bb', '1', '1', [], 'aaa'))
print(participation.participant) #prints none

I think I found the error, posting a PR soon.
manulera added a commit to manulera/pySBOL2 that referenced this issue Apr 11, 2024
@manulera
closes SynBioDex#430
0bf5ce8
@manulera manulera mentioned this issue Apr 11, 2024
Merged
jakebeal added a commit that referenced this issue Apr 11, 2024
@jakebeal
Merge pull request #431 from manulera/issue_430
c897809 
closes #430
jakebeal added a commit that referenced this issue Apr 11, 2024
@jakebeal
Undo malfunctioning patch for #430
9338566
@jakebeal
Copy link
Collaborator

The patch committed was not working correctly. I am going undoing it and we can try again with a new patch that the GitHub actions actually run against

@jakebeal jakebeal reopened this Apr 11, 2024
@manulera
Copy link
Member Author

manulera commented Apr 11, 2024 •
edited
Loading

This is fixed now. This should be fixed with #436

I don't understand what is the use-case for the if statement. When is self._sbol_owner None, and why not assign the property in that case and add an empty list instead?

I noticed that there is other similar if statements in the file, maybe it would be good to review them.

manulera added a commit to manulera/pySBOL2 that referenced this issue Apr 11, 2024
@manulera
closes SynBioDex#430
e9c4413
This was referenced Apr 11, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

closes #430 manulera/pySBOL2
closes #430 manulera/pySBOL2
2 participants
@jakebeal @manulera