Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigOptions #361

Open
JMante1 opened this issue Dec 22, 2021 · 2 comments
Open

ConfigOptions #361

JMante1 opened this issue Dec 22, 2021 · 2 comments
Assignees

Comments

@JMante1
Copy link

JMante1 commented Dec 22, 2021

It seems like a lot of the config options have disappeared. I was looking for the SBOL3 equivalent of sbol2.Config.setOption(sbol2.ConfigOptions.SBOL_TYPED_URIS, False) which doesn't seem to exist. However, it seems like it is set somewhere as in object.py line 170 the property is checked.

@tcmitchell
Copy link
Collaborator

Yes, you are correct about all of this.

It seems like a lot of the config options have disappeared.

They didn't really disappear, they never existed. These config options did not get carried forward from pySBOL2 because most or all of them are unnecessary in pySBOL3.

I was looking for the SBOL3 equivalent of sbol2.Config.setOption(sbol2.ConfigOptions.SBOL_TYPED_URIS, False) which doesn't seem to exist.

All URIs are typed URIs in SBOL 3. See Section 5 of the SBOL 3 specification for more information. While non-typed URIs are allowed, they are discouraged by the specification. pySBOL3 makes it very difficult to use anything but typed URIs.

However, it seems like it is set somewhere as in object.py line 170 the property is checked.

This is true. It is also true that this code is broken and is not used. You missed the comment block and the NotImplementedError at the beginning of the function in which you found the erroneous SBOL_TYPED_URIS check. You probably also noticed that SBOL_TYPED_URIS does not appear anywhere else in the code. Issue #132 (referenced in the comment block I linked) documents the problems with this function, and what needs to be done with it.

@tcmitchell
Copy link
Collaborator

@JMante1 is there anything more to do on this issue? Do you need any additional assistance with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants