Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix file system casing #33

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix file system casing #33

wants to merge 3 commits into from

Conversation

nyanhp
Copy link
Contributor

@nyanhp nyanhp commented Jun 3, 2024 •
edited by gaelcolas
Loading

Pull Request (PR) description

Using proper capitalization as used in the module folder structure to enable Linux usage as well. Tested with the DscWorkshop project while attempting to build Machine Configuration packages :)

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof and comment-based
    help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@nyanhp
Copy link
Contributor Author

nyanhp commented Jun 3, 2024

Sorry @gaelcolas , but the build task keeps failing. I've added PlatyPS after the first failed build, now it fails with a different error. The change I did was just file path casing ;)

@johlju
Copy link

johlju commented Jun 3, 2024

I will look into this. It should not run two of the tasks if PlatyPS is not available. I will let you know when you can revert the change to required modules.

@johlju johlju mentioned this pull request Jun 3, 2024
Merged
8 tasks
@johlju
Copy link

johlju commented Jun 3, 2024 •
edited
Loading

Okay, a fix has now been released in DocGenerator so if PlatyPS is removed from the RequiredModules.ps1 this PR should pass build.

@johlju
Copy link

johlju commented Jun 4, 2024

We have to wait for @gaelcolas to merge this as I don't have permission in this repo. 🙂

@raandree
Copy link
Contributor

raandree commented Oct 21, 2024 •
edited
Loading

@gaelcolas, can we merge this AFTER having done a full release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johlju johlju johlju approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Folder Name for crossplatform use
3 participants
@nyanhp @johlju @raandree