Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installation doesnt work / alternative install #117

Open
jrab66 opened this issue Feb 15, 2024 · 6 comments
Open

installation doesnt work / alternative install #117

jrab66 opened this issue Feb 15, 2024 · 6 comments

Comments

@jrab66
Copy link

jrab66 commented Feb 15, 2024

I did try both homebrew and pipx installation but fails due to error with, I did build the cli from source and works with a local pipx install.

pipx installation fails:

pip seemed to fail to build package: PyYAML==6.0

homebrew doesnt show error but folder is not created.

==> /home/linuxbrew/.linuxbrew/Cellar/strimzi-kafka-cli/0.1.0a68/libexec/bin/pip install strimzi-kafka-cli==0.1.0a68
Last 15 lines from /home/jrab66/.cache/Homebrew/Logs/strimzi-kafka-cli/02.pip:
2024-02-15 16:20:26 +0000

/home/linuxbrew/.linuxbrew/Cellar/strimzi-kafka-cli/0.1.0a68/libexec/bin/pip
install
strimzi-kafka-cli==0.1.0a68


If reporting this issue please do so at (not Homebrew/brew or Homebrew/homebrew-core):
  https://github.com/systemcraftsman/homebrew-strimzi-kafka-cli/issues

pipx installation working after build it from source.

pipx install  strimzi-kafka-cli-0.1.0a75.tar.gz strimzi-kafka-cli 
⚠️  File exists at /home/jrab66/.local/bin/kfk and points to /home/jrab66/.local/bin/kfk, not /home/jrab66/.local/share/pipx/venvs/strimzi-kafka-cli/bin/kfk. Not modifying.
  installed package strimzi-kafka-cli 0.1.0a75, installed using Python 3.12.2
  These apps are now globally available
    - kfk (symlink missing or pointing to unexpected location)
done! ✨ 🌟 ✨

kfk working :

(⎈|kind-kind:N/A) jrab66@fedora  ~/strimzi-kafka-cli/dist   main  kfk
Usage: kfk [OPTIONS] COMMAND [ARGS]...

  Strimzi Kafka CLI.

Options:
  --version  Show the version and exit.
  --help     Show this message and exit.

Commands:
  acls              Manages ACLs on Kafka.
  clusters          Creates, alters, deletes, describes Kafka cluster(s).
  configs           Adds/Removes entity config for a topic, client, user...
  connect           Creates, alters, deletes, describes Kafka Connect...
  console-consumer  Reads data from Kafka topics and outputs it to...
  console-producer  Reads data from standard input and publish it to Kafka.
  env               Prints the environment variable values for Strimzi...
  operator          Installs/Uninstalls Strimzi Kafka Operator.
  topics            Creates, alters, deletes, describes Kafka topic(s).
  users             Creates, alters, deletes, describes Kafka users(s).
(⎈|kind-kind:N/A) jrab66@fedora  ~/Documents/strimzi-kafka-cli/dist   main  kfk --version                                                            
CLI Version: 0.1.0a75
Strimzi Version: 0.37.0
Kubectl Version: v1.28.3

@mabulgu
Copy link
Member

mabulgu commented Feb 16, 2024

Hi @jrab66 . It seems that the Homebrew version is left outdated. I renewed the version. So pls try this out by deleting the tap and adding the tap and installing again. Pls let me know if this works. Like pipx, you should get the right version this time.

@mabulgu
Copy link
Member

mabulgu commented Feb 16, 2024

Hi @jrab66 . It seems that the Homebrew version is left outdated. I renewed the version. So pls try this out by deleting the tap and adding the tap and installing again. Pls let me know if this works. Like pipx, you should get the right version this time.

@jrab66 Also checked pipx and workes fine on my end:

  installed package strimzi-kafka-cli 0.1.0a75, installed using Python 3.11.5
  These apps are now globally available
    - kfk
done! ✨ 🌟 ✨```

@jrab66
Copy link
Author

jrab66 commented Feb 28, 2024

it works @mabulgu closing this issue, thanks!

@jrab66 jrab66 closed this as completed Feb 28, 2024
@nrhvyc
Copy link

nrhvyc commented Mar 20, 2024

This still seems to be an issue for me.
pip seemed to fail to build package: PyYAML==6.0

Also, when I tried installing via pipx instead, it complains
pipx install ~/Downloads/strimzi-kafka-cli-0.1.0-alpha75.tar.gz strimzi-kafka-cli ERROR: Package 'strimzi-kafka-cli' requires a different Python: 3.12.2 not in '<=3.12.0,>=3.8'

Seems like not allowing a patch version to of python 3.12.2 over 3.12.0 seems overly restrictive.

@mabulgu mabulgu reopened this Mar 20, 2024
@mabulgu
Copy link
Member

mabulgu commented Mar 20, 2024

@nrhvyc I've reopened the issue and looking into it. Thanks for the heads up @nrhvyc , and you are right about the version restriction. That happened after we switched the project to use pyproject.toml. having <=3.12 should be fine I guess, I will try.

@mabulgu
Copy link
Member

mabulgu commented Mar 22, 2024

I found a bug regarding an inconsistency between the Language::Python::Virtualenv library and python 3.12 so I updated the homebrew formula to use the python version 3.11 as max.

In order to use the hombrew installation properly do the following:

# Untap the repo
brew untap systemcraftsman/strimzi-kafka-cli
# Tap the repo
brew tap systemcraftsman/strimzi-kafka-cli
# Run the install
brew install systemcraftsman/strimzi-kafka-cli

@nrhvyc pipx install strimzi-kafka-cli worked fine for me. I did a few version upgrades yesterday, which are not directly related because we already had the requires-python = ">=3.8,<3.13" in the version you were trying to install. However it might worth giving it another try with the new version. Please be sure to remove any other installations first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants