Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[S1] 모든 BottomSheet 데스크탑뷰 너비 제한 #608

Open
3 tasks
lydiacho opened this issue Feb 19, 2024 · 0 comments · Fixed by #617
Open
3 tasks

[S1] 모든 BottomSheet 데스크탑뷰 너비 제한 #608

lydiacho opened this issue Feb 19, 2024 · 0 comments · Fixed by #617
Assignees
@lydiacho
Labels
🐞 BugFix 버그 수정 👨‍👩‍👧‍👦 Common 공통 컴포넌트

Comments

@lydiacho
Copy link
Member

lydiacho commented Feb 19, 2024 •
edited
Loading

💚 어떤 기능인가요?

react-modal-sheet 라이브러리를 사용해서 바텀시트를 구현한 곳들의 스타일을 수정합니다

✅ To Dos

  • 중복되는 BottomSheet styling 파악해서 공통 컴포넌트로 분리하기
  • 너비 stretch 문제 해결
  • 모든 BottomSheet 사용처에 적용
@lydiacho lydiacho added 🐞 BugFix 버그 수정 👨‍👩‍👧‍👦 Common 공통 컴포넌트 labels Feb 19, 2024
@lydiacho lydiacho self-assigned this Feb 19, 2024
@lydiacho lydiacho moved this to In Progress in Tattour-Client-Board Feb 19, 2024
lydiacho added a commit that referenced this issue Feb 19, 2024
@lydiacho
Merge branch 'develop' of https://github.com/TEAM-TATTOUR/tattour-client
eaa52ec 
 into S1/#608-fix-bottom-sheet
lydiacho added a commit that referenced this issue Feb 22, 2024
@lydiacho
Merge branch 'develop' of https://github.com/TEAM-TATTOUR/tattour-client
021065d 
 into S1/#608-fix-bottom-sheet
@lydiacho lydiacho mentioned this issue Feb 22, 2024
Merged
2 tasks
@lydiacho lydiacho linked a pull request Feb 24, 2024 that will close this issue
[S1] 공통 BottomSheet 적용 #617
Merged
2 tasks
lydiacho added a commit that referenced this issue Feb 24, 2024
@lydiacho
Merge pull request #617 from TEAM-TATTOUR/S1/#608-fix-bottom-sheet
a25717e 
[S1] 공통 BottomSheet 적용
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lydiacho lydiacho

Labels
🐞 BugFix 버그 수정 👨‍👩‍👧‍👦 Common 공통 컴포넌트
Projects
Tattour-Client-Board
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[S1] 공통 BottomSheet 적용 TEAM-TATTOUR/tattour-client
1 participant
@lydiacho