Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare extension for x64 build #49

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

Prepare extension for x64 build #49

wants to merge 16 commits into from

Conversation

Kenzzer
Copy link
Collaborator

@Kenzzer Kenzzer commented Jan 26, 2024 •
edited by KitRifty
Loading

  • Updated AMBuild scripts to depend on alliedmodders's hl2sdk-manifests repository
  • Updated the package script to distribute the 64bits extension
  • Removed the copy of CDetour and replaced it with the one from sourcemod directly (it supports x86_64 assembly, our copy doesn't)
  • Fixed a few remaining instances where PtrToPawnAddress should have been used
  • Added --targets x86,x86_64 to the CI script

TO-DO :

  • Make a x86_64 assembly variant of the input function, available in IEntityDataMapInputFuncDelegate::Alloc
    • Linux
    • Windows

@Kenzzer
Copy link
Collaborator Author

Kenzzer commented Jan 26, 2024

This PR will also require alliedmodders/hl2sdk-manifests#4 to land before we can actually merge.

Kenzzer and others added 12 commits February 6, 2024 19:39
@Kenzzer
fix various sections of the ext for x64
8aeefd4
@Kenzzer
update datacontainer
441e2f2
@KitRifty
Update manifests submodule
d13420d 
Add missing SDK_OnMetamodCreateInterface definition
@KitRifty
Fix -Wno-implicit-exception-spec-mismatch flag not being applied
2308463
@KitRifty
Use MM 1.12 and SM 1.12 (master)
31064b6
@KitRifty
Set m_scriptInstance type to HSCRIPT
1b3954b 
Don't omit frame pointer
@KitRifty
Fix entity input functions crashing on invocation
81e3042 
- In x64, there's a tendency for jmp calls to be used to go to another function instead of using call. There's probably some stack fuckery going on here since call pushes the return address on the stack. However, since we don't need to use the stack, we can substitute this with a simple jmp reg call instead, which also fixes the crash.
@KitRifty
🪟 Update gamedata + fix compilation
95d0fcd 
Untested, but probably correct
Add more comments on getting sigs
@KitRifty
Fix edge case with passing 0 to PawnAddressToPtr
e38c5da
@KitRifty
Fix "CBaseAnimating::SequenceDuration" signature
c36f2fe
@KitRifty
Reimplement CBaseAnimating::SequenceDuration
9e13516 
Replace sig with Studio_Duration signature
Fetch m_flPoseParameter array member
@KitRifty
Add studiohdr checks to SequenceDuration
b30aaef 
Add source studio.cpp
@Kenzzer
Copy link
Collaborator Author

Kenzzer commented Mar 30, 2024

Leaving a public note here. The PR is still on our radar however we're waiting on the (hopefully positive) resolution of the sourcepawn's Address type crisis. This currently breaks the extension in major ways, and while we could come up with a fix of our own, we cannot be hasty about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kenzzer @KitRifty