Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResideInAssembly should not match the fully qualified name #290

Open
alexanderlinne opened this issue Aug 23, 2024 · 2 comments
Open

ResideInAssembly should not match the fully qualified name #290

alexanderlinne opened this issue Aug 23, 2024 · 2 comments

Comments

@alexanderlinne
Copy link
Collaborator

When using

Types()
    .That()
    …
    .Should()
    .OnlyDependOn(Types().That().ResideInAssembly("System.Console"))
    .Check(Architecture);

This does currently not work, because ResideInAssembly matches the fully qualified name like System.Console, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a. This is unexpected, the condition should instead only match the name of the assembly.

@fgather
Copy link
Contributor

fgather commented Sep 3, 2024

You are correct, for most use-cases this would be the expected way.
However in those set-ups:
#292
🤔

@alexanderlinne
Copy link
Collaborator Author

Ideally this would build upon #130 with a syntax like Types().That().ResideInAssembliesThat().HaveName(…) or Types().That().ResideInAssembliesThat().HaveFullName(…). That would also make it more clear what part of the name we are matching when reading the code of a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants