Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArchUnit does not load the names of referenced assemblies for dependent / recursively loaded assemblies #311

Open
made-by-karl opened this issue Oct 10, 2024 · 0 comments · May be fixed by #319
Open

ArchUnit does not load the names of referenced assemblies for dependent / recursively loaded assemblies #311

made-by-karl opened this issue Oct 10, 2024 · 0 comments · May be fixed by #319

Comments

@made-by-karl
Copy link

ArchLoader.LoadModule() sets the name of referenced assemblies only for the requested assembly, not for other loaded assemblies.

I think you can retrieve this data from an AssemblyDefinition via the MainModule.AssemblyReferences property, so instead of calling
_archBuilder.AddAssembly(assemblyDefinition, false, null) you could set the referenced assembly names inside of the AddAssembly() method.

I'd like to open a PR for this issue.
made-by-karl added a commit to made-by-karl/ArchUnitNET that referenced this issue Oct 25, 2024
@made-by-karl
fill the ReferencedAssemblyNames property for all loaded assemblies
d9bf4cc 
Fixes issue TNG#311
@made-by-karl made-by-karl linked a pull request Oct 25, 2024 that will close this issue
Open
made-by-karl added a commit to made-by-karl/ArchUnitNET that referenced this issue Oct 25, 2024
@made-by-karl
fill the ReferencedAssemblyNames property for all loaded assemblies
fbdec12 
Fixes issue TNG#311

Signed-off-by: Karl Rhenius <[email protected]>
made-by-karl added a commit to made-by-karl/ArchUnitNET that referenced this issue Oct 25, 2024
@made-by-karl
fill the ReferencedAssemblyNames property for all loaded assemblies
7bb008e 
Fixes issue TNG#311

Signed-off-by: Karl Rhenius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fill the ReferencedAssemblyNames property for all loaded assemblies #311 made-by-karl/ArchUnitNET
1 participant
@made-by-karl