Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[!!!][TASK] Remove registered 'class' handling in abstract form VH #1146

Open
TYPO3IncTeam opened this issue Oct 26, 2024 · 0 comments
Open

Comments

@TYPO3IncTeam
Copy link
Collaborator

ℹ️ View this commit on Github
👥 Authored by Christian Kuhn [email protected]
✔️ Merged by Garvin Hicking [email protected]

Commit message

[!!!][TASK] Remove registered 'class' handling in abstract form VH

Do not handle manually registered 'class' attribute in
setErrorClassAttribute() anymore.

Resolves: #105485
Related: #105377
Related: #104412
Releases: main
Change-Id: Id688b797b2342daa950eaa4aa4a44d5b152020a9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86801
Reviewed-by: Garvin Hicking [email protected]
Tested-by: Garvin Hicking [email protected]
Tested-by: core-ci [email protected]
Tested-by: Anja Leichsenring [email protected]
Reviewed-by: Anja Leichsenring [email protected]
Reviewed-by: Nikita Hovratov [email protected]
Tested-by: Nikita Hovratov [email protected]

➗ Modified files

14.0/Breaking-105377-DeprecatedFunctionalityRemoved.rst
@@ -236,6 +236,9 @@ The following fallbacks have been removed:
 - Allowing instantiation of :php:`\TYPO3\CMS\Core\Imaging\IconRegistry` in ext_localconf.php
 - Accepting a comma-separated list of fields as value for the `columnsOnly` parameter
 - Support for extbase repository magic :php:`findByX()`, :php:`findOneByX()` and :php:`countByX()` methods
+- Fluid view helpers that extend :php:`\TYPO3\CMS\Fluid\ViewHelpers\Form\AbstractFormFieldViewHelper`
+  should no longer register :html:`class` attribute and should rely on attribute auto registration
+  for the error class to be added correctly.
 
 The following upgrade wizards have been removed:
 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants