Route context not updated if new context is returned in beforeLoad

[nklhtv]

Which project does this relate to?

Router

Describe the bug

while updating from 1.45.4 to 1.91.3 i noticed a new behavior related to router context.
if a new context value is returned from beforeLoad it remains cached and new values for that same context key are not received.

Your Example Website or App

https://stackblitz.com/edit/tanstack-router-hsasr5ei?file=src%2Fmain.tsx

Steps to Reproduce the Bug or Issue

1. click "refresh" button ONCE

2. auth.token and _auth.token have the same value

3. click "refresh" button again

4. auth.token and _auth.token have different values

5. remove the return statement from the indexRoute's beforeLoad

6. refresh the app and do 1. 2. & 3.

7. the behavior is different. auth.token and _auth.token have the same value at all times

Expected behavior

each call to beforeLoad should receive the latest context even if some of the keys ware overridden by beforeLoad result in the previous call. this used to be the case in 1.45.4

Screenshots or Videos

Screen.Recording.2024-12-20.at.20.22.34.mov

Platform

• OS: mac
• Browser: firefox
• Version: 130

Additional context

No response

[schiller-manuel]

can your create a minimal failing unit test case as a PR? still not fully understanding what's going on here

[nklhtv]

beforeLoad used to be called with match.routeContext:

router/packages/react-router/src/router.ts

Line 1920 in da9d52a

context: routeContext,

but there is no routeContext since https://github.com/TanStack/router/pull/2104/files

[schiller-manuel]

beforeLoad is called with the parent context
https://github.com/TanStack/router/blob/main/packages%2Freact-router%2Fsrc%2Frouter.ts#L2420

still don't understand how that was different or what you need here.

[nklhtv]

https://github.com/user-attachments/assets/b57854e5-2b6f-4b54-92dd-edf2971624cc
the issue is that beforeLoad gets called with cached values of context.auth even when the RouterProvider is rerendered with new context.auth. Is that clear?

[nklhtv]

beforeLoad is called with the parent context https://github.com/TanStack/router/blob/main/packages%2Freact-router%2Fsrc%2Frouter.ts#L2420

still don't understand how that was different or what you need here.

which i guess is a different value than routeContext from 1.45.4?
this.getMatch used to return both context: TAllContext and routeContext: TRouteContext

router/packages/react-router/src/Matches.tsx

Line 55 in da9d52a

routeContext: TRouteContext