Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getToggleAllRowsSelectedHandler doesn't take into account enableSubRowSelection property #5116

Open
2 tasks done
gax97 opened this issue Oct 5, 2023 · 0 comments · May be fixed by #5274
Open
2 tasks done

getToggleAllRowsSelectedHandler doesn't take into account enableSubRowSelection property #5116

gax97 opened this issue Oct 5, 2023 · 0 comments · May be fixed by #5274

Comments

@gax97
Copy link

gax97 commented Oct 5, 2023

Describe the bug

Even if the table is provided with enableSubRowSelection: false, calling a handler from getToggleAllRowsSelectedHandler will still select all rows.

Your minimal, reproducible example

https://codesandbox.io/p/sandbox/focused-ben-wfks52?embed=1&file=%2Fsrc%2Fmain.tsx%3A148%2C5

Steps to reproduce

  1. Select all columns from the header
  2. Expandable columns are selected even if the enableSubRowSelection = false

Expected behavior

Expandable rows should not be selected if enableSubRowSelection = false

How often does this bug happen?

Every time

Screenshots or Videos

No response

Platform

Chrome, Mac

react-table version

8.10.3

TypeScript version

5.1.3

Additional context

No response

Terms & Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant