Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commonTaskQueryOracle doesn't check permissions #2304

Open
ryzheboka opened this issue Jun 22, 2023 · 1 comment
Open

commonTaskQueryOracle doesn't check permissions #2304

ryzheboka opened this issue Jun 22, 2023 · 1 comment
Labels

Comments

@ryzheboka
Copy link
Contributor

commonTaskQueryOracle doesn't have an authorization check. That's why during selectAndClaim, an Exception is thrown except returning an empty Optional. The exception looks like this:

SystemException [errorCode=ErrorCode [key=CRITICAL_SYSTEM_ERROR, messageVariables={}], message=Did not find a Workbasket for task (Id=TKI:0254453f-d8e1-4515-9f0a-734e98371baf,Workbasket=WBI:64f04353-e7c0-4234-8db8-a85a3ba10e82)]
	at pro.taskana.task.internal.TaskServiceImpl.addWorkbasketSummariesToTaskSummaries(TaskServiceImpl.java:2012)
	at pro.taskana.task.internal.TaskServiceImpl.appendComplexAttributesToTaskSummariesWithoutPartitioning(TaskServiceImpl.java:1168)

The reason for the exception is the following: The query for selectAndClaim returns a Task althjough it shouldn't. Then, TASKANA tries to append a Workbasket to this Task and fails because of missing permission. @arolfes , was it intended that Oracle query doesn't have authorization checks? Could please look into it?

@nyuuyn
Copy link
Contributor

nyuuyn commented Aug 2, 2023

Is there a way to reproduce this problem via the test available ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

2 participants