From b63fef2b361138fd87e231853551215415ddd748 Mon Sep 17 00:00:00 2001
From: Charlie Mordant <cmordant1@gmail.com>
Date: Fri, 17 May 2024 08:43:46 +0200
Subject: [PATCH] typesafe for json to jdl

---
 jdl/converters/json-to-jdl-converter.spec.ts | 2 ++
 jdl/converters/types.ts                      | 8 ++++----
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/jdl/converters/json-to-jdl-converter.spec.ts b/jdl/converters/json-to-jdl-converter.spec.ts
index b45dae986356..8925a9d5d48f 100644
--- a/jdl/converters/json-to-jdl-converter.spec.ts
+++ b/jdl/converters/json-to-jdl-converter.spec.ts
@@ -355,6 +355,7 @@ describe('jdl - JSONToJDLConverter', () => {
       beforeEach(() => {
         jdl = convertSingleContentToJDL({
           'generator-jhipster': {
+            baseName: 'x',
             microfrontends: [
               {
                 baseName: 'foo',
@@ -375,6 +376,7 @@ describe('jdl - JSONToJDLConverter', () => {
       it('should not fail', () => {
         convertSingleContentToJDL({
           'generator-jhipster': {
+            baseName: 'x',
             blueprints: null,
             microfrontends: undefined,
           },
diff --git a/jdl/converters/types.ts b/jdl/converters/types.ts
index 6e1e64067a9c..916293ea791c 100644
--- a/jdl/converters/types.ts
+++ b/jdl/converters/types.ts
@@ -69,11 +69,11 @@ export type JSONGeneratorJhipsterContent = {
   serviceDiscoveryType?: string;
   skipClient?: boolean;
   skipUserManagement?: boolean;
-  testFrameworks: string[];
-  websocket: string;
+  testFrameworks?: string[];
+  websocket?: string;
   promptValues?: Partial<JSONGeneratorJhipsterContent>;
-  blueprints?: JSONBlueprint[];
-  microfrontends?: JSONMicrofrontend[];
+  blueprints?: JSONBlueprint[] | null;
+  microfrontends?: JSONMicrofrontend[] | null;
 } & Record<string, any>;
 
 export type PostProcessedJSONGeneratorJhipsterContent = Omit<