New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Station X and Y coordinates inverted in Pluto notebook #207

Open

tkoskela opened this issue Jan 14, 2022 · 1 comment

Labels

bug

Member

tkoskela commented Jan 14, 2022 •

edited

Loading

Based on visual inspection of @DanGiles animations 😅

To be clear, this only affects the visualisation, not the DA code

tkoskela added the bug label

Member

giordano commented Jan 17, 2022

I haven't rerun the notebook, but looking at #189 (comment) the plot seem to have the right axes, but note

ParticleDA.jl/extra/Plot_output_pluto.jl

Lines 118 to 121 in 247c6a0

    
           # Note that for heatmaps we need to permute the dimensions of the z matrix 
        
           p1 = heatmap(x, y, z_t'; title="True $(lowercase(field_desc))") 
        
           p2 = heatmap(x, y, z_avg'; title="Assimilated $(lowercase(field_desc))") 
        
           p3 = heatmap(x, y, z_std'; title="Std of assimilated $(lowercase(field_desc))")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment