Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search in Recent Files #4179

Open
liushuqi-2022 opened this issue May 25, 2024 · 2 comments
Open

Search in Recent Files #4179

liushuqi-2022 opened this issue May 25, 2024 · 2 comments
Labels
Area-Search Related to file search. Issue-Feature A feature request or improvement.

Comments

@liushuqi-2022
Copy link

Describe the bug
Search in recent files not working

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Recent files'
  2. Click on Search button
  3. Enter search text
  4. See error

Expected behavior
The file just searched should be displayed.

Screenshots
imageimage

Smartphone (please complete the following information):

  • Device: [e.g. Google Pixel XL]
  • OS: [e.g. Android 8]
  • Rooted: [e.g. No]
  • Version: [e.g. 3.10]

Additional context
Add any other context about the problem here.

@VishnuSanal VishnuSanal changed the title Cannot search in Recent files Search in Recent Files May 30, 2024
@VishnuSanal VishnuSanal added Area-Search Related to file search. Issue-Feature A feature request or improvement. labels May 30, 2024
@Obolrom
Copy link
Contributor

Obolrom commented Sep 19, 2024

@VishnuSanal
@liushuqi-2022
Search generally works fine.
However, by default is used MainActivityViewModel::basicSearch method for search.
When we click "Try indexed search" or "Try deep search" then MainActivityViewModel::indexedSearch or MainActivityViewModel::deepSearch is used. And those methods work fine.

Maybe we should change the default search method to "indexed"?

Screen_recording_20240919_151257.mp4

@VishnuSanal
Copy link
Member

hi @Obolrom, thanks for your interest in help develop amaze! but, I didn't quite get you -- the issue is with search items not being consistent when searching in recent files. this must be fixed if we check the current location (CUSTOM path in the enum) & target the search to the recent files.

(question to self: would this also work for quick access files? 🤔)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Search Related to file search. Issue-Feature A feature request or improvement.
Projects
None yet
Development

No branches or pull requests

3 participants