Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Settings categorization #9587

Open
6 tasks done
opusforlife2 opened this issue Dec 23, 2022 · 17 comments · Fixed by #10876
Open
6 tasks done

New Settings categorization #9587

opusforlife2 opened this issue Dec 23, 2022 · 17 comments · Fixed by #10876
Assignees
@pratyaksh1610
Labels
feature request Issue is related to a feature in the app good first issue Easy/simple issues perfect for newcomers to get involved in the project GUI Issue is related to the graphical user interface rewrite Issues and PRs related to rewrite

Comments

@opusforlife2
Copy link
Collaborator

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

Hey there. The team went through several rounds of discussion regarding the current Settings tree/layout, and finalised a new one that should hopefully make the menus much easier and intuitive to navigate.

Here is the current layout:

  • Video and audio
  • Download
  • Appearance
  • History and cache
  • Content
  • Notifications
  • Updates (not on debug)
  • Debug (not on release)

Here is the new layout the team has decided on:

  • Video and audio (rename to 'Player')
    • Resolution and format
      • Include seekbar thumbnail setting here
    • External player
    • Player notifications
    • Move Behaviour section into its own top level menu, because it hasn't been player-specific for ages.
  • Behaviour
  • Download
    • SAF and other filesystem-related settings need to be in one place. Remove from here.
  • Appearance (rename to "Look and feel")
    • Move player notification menu to 'Video and audio'.
    • Move Captions to 'Video and audio'.
  • History and cache
  • Content (the worst offender)
    • Language section in its own top-level menu.
    • Content of main page - move to Appearance
    • PeerTube instance - move to PeerTube submenu under Services
    • Age toggles remain here (since they apply to YT and PT both).
    • YouTube-specific toggles - move to YouTube submenu under services
    • Thumbnails, comments, similar videos, description - move to Appearance
    • Database import/export - move to Backup and restore/Import and export
    • Feed section in its own top-level menu.
  • Feed
    • New stream notifications
  • Services (services without specific menus could have their submenus greyed out or invisible)
    • YouTube
      • Meta info and similar YT-specific stuff.
    • Soundcloud
    • media.ccc.de
    • Bandcamp
    • PeerTube
      • Instances
  • Language
  • Import/export or Backup/restore
    • Put SAF here, for now.
  • Updates (not on debug, only on builds signed by us)
  • Debug (not on release)

Why do you want this feature?

The current layout has been a struggle to fit new settings into, and has become very non-intuitive.

Additional information

No response
@opusforlife2 opusforlife2 added feature request Issue is related to a feature in the app good first issue Easy/simple issues perfect for newcomers to get involved in the project GUI Issue is related to the graphical user interface labels Dec 23, 2022
@SameenAhnaf
Copy link
Collaborator

SameenAhnaf commented Dec 23, 2022 •
edited
Loading

Uh oh! #9580 is already on the way. Should we discuss more about this? Personally, I don't find Feed section intuitive. The word Notifications can be more easily understood.

Related to History and Cache: #6257 (comment)

@ChunkyProgrammer
Copy link

Will the subscription json file be added to the import/export as well? Just wondering as every few months we get an issue about how to import new pipe subscriptions and i think it might be a good idea to include it here as well as a description indicating that you could use it to import subscriptions into other youtube clients (ex: invidious, piped or freetube)

@opusforlife2
Copy link
Collaborator Author

Right now, the focus is on just rearranging the currently existing settings. After this is done, we can consider adding or removing settings, etc.

Personally, I don't find Feed section intuitive. The word Notifications can be more easily understood.

We can ask people to test the PR and give feedback about this.

9580 is already on the way

We can ask @pratyaksh1610 if he would like to take this up. What say, Pratyaksh?

@opusforlife2
Copy link
Collaborator Author

Meanwhile, @ChunkyProgrammer you can add your opinion to #3192.

@somos61
Copy link

somos61 commented Dec 24, 2022

How about to merge YouTube and PeerTube settings in Services section and remove Content section at all (worst offender indeed). Not clear what exactly will remain there since pretty much everything (except age toggles) moving to it's own sections

@opusforlife2
Copy link
Collaborator Author

Maybe. Testing a PR would help iron these things out.

@pratyaksh1610
Copy link
Contributor

@opusforlife2 Sure, I will work on this.

@pratyaksh1610
Copy link
Contributor

Should I raise a new PR for the same or continue working on the same branch and modify it ? #9580

@opusforlife2
Copy link
Collaborator Author

@pratyaksh1610 Can you update the branch name? I think everything else is editable in an existing PR, but I think that needs a new PR.

@Stypox Stypox mentioned this issue Jan 1, 2023
Merged
5 tasks
@SameenAhnaf SameenAhnaf mentioned this issue Jan 2, 2023
Closed
5 tasks
@opusforlife2 opusforlife2 changed the title New Settings layout New Settings categorization Jan 2, 2023
@abhi835
Copy link

abhi835 commented Feb 2, 2023

can i work on it

@opusforlife2
Copy link
Collaborator Author

@pratyaksh1610 Could you confirm if you're still working on this?

@pratyaksh1610
Copy link
Contributor

I am working on it. Lost track of this due to my exams.

@opusforlife2
Copy link
Collaborator Author

@abhi835 You're welcome to take up some other issue you're interested in.

@opusforlife2
Copy link
Collaborator Author

@pratyaksh1610 Is this still on your plate?

@opusforlife2 opusforlife2 mentioned this issue Sep 21, 2023
Merged
5 tasks
@snaik20
Copy link
Contributor

snaik20 commented Oct 9, 2023

Hi @opusforlife2,

  • Can you confirm if we have icons for the new settings?
  • Also, are the order and items of the settings in the description still relevant to the current state of the app?

@opusforlife2
Copy link
Collaborator Author

@snaik20 Thanks for having a look! What you see in the description is all we have right now. So icons will have to be discussed.

Regarding the order, it will have to be rechecked. Off the top of my head I can't think of anything that needs to be changed. So maybe any modifications that come up can be discussed in the PR?

Oh, but before there's further movement on this, let's ensure we have a go ahead from the team. @TobiGr?

@snaik20 snaik20 mentioned this issue Oct 12, 2023
Closed
5 tasks
@snaik20
Copy link
Contributor

snaik20 commented Oct 12, 2023

Hi @opusforlife2, @TobiGr,

Made some changes in #10490.

Please let me know if you have any feedback around the changes and icons used/missing.

snaik20 added a commit to snaik20/NewPipe that referenced this issue Feb 26, 2024
@snaik20
Initial setup for Settings page redesign with debug settings
89645fa 
- Added a new settings option to enable the settings page redesign.
- This option allows us to integrate and test the new settings page
  gradually, minimizing disruptions to the current behavior.
- Reused the rest of the debug menu to reflect in the new settings page.
- Verified the functionality of all debug settings.

Next plan:
- Create PRs to gradually add all the subsections as detailed in
  TeamNewPipe#9587.

Note:
- This PR prepares for upcoming updates by setting up the necessary
  changes for follow-up PRs.
@snaik20 snaik20 mentioned this issue Feb 26, 2024
Closed
5 tasks
snaik20 added a commit to snaik20/NewPipe that referenced this issue Feb 26, 2024
@snaik20
Implementation of player settings page in Settings page redesign
5ca8586 
- Added new files for the Fragment and xml related to the player
  settings page.
- Implemented the player settings page per the description in
  TeamNewPipe#9587.
- These changes facilitate easier switching between current and new behaviors.
- They also lay the groundwork for easier cleanup when the new design
  is approved and enabled by default.

Video:
- https://github.com/TeamNewPipe/NewPipe/assets/87667048/00385bbb-6a2f-4ce5-b6b9-6cf1cb5c5636
@snaik20 snaik20 mentioned this issue Feb 26, 2024
Closed
5 tasks
This was referenced Mar 9, 2024
Closed
Merged
@snaik20 snaik20 mentioned this issue Jun 24, 2024
Open
@ShareASmile ShareASmile added the rewrite Issues and PRs related to rewrite label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pratyaksh1610 pratyaksh1610

Labels
feature request Issue is related to a feature in the app good first issue Easy/simple issues perfect for newcomers to get involved in the project GUI Issue is related to the graphical user interface rewrite Issues and PRs related to rewrite
Projects
None yet
Milestone
No milestone
8 participants
@opusforlife2 @ShareASmile @pratyaksh1610 @ChunkyProgrammer @SameenAhnaf @snaik20 @abhi835 @somos61