Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pac3 outfits lag behind with utime installed #7

Open
thegrb93 opened this issue Jul 12, 2019 · 11 comments
Open

Pac3 outfits lag behind with utime installed #7

thegrb93 opened this issue Jul 12, 2019 · 11 comments

Comments

@thegrb93
Copy link

CapsAdmin/pac3#767

@Nayruden
Copy link
Member

Thanks, we'll keep this open as a record of the conflict.

@Nayruden Nayruden changed the title Causes issues with pac3 pac3 causes lag Jul 12, 2019
@thegrb93 thegrb93 changed the title pac3 causes lag Pac3 outfits lag behind with utime installed Jul 12, 2019
@thegrb93
Copy link
Author

thegrb93 commented Jul 12, 2019

Fixed the title. Fyi, the issue seems to be from doing traces within the Panel:Think, perhaps if that was moved to Gamemode;Think, it might be fixed. Idk though

@thegrb93
Copy link
Author

You also ought to add a bug label.

@Nayruden
Copy link
Member

We use the bug label to signal a bug in the codebase hosting the issue tracker. Why do you think the trace is the cause of the conflict? UTime has been tested under a variety of conditions for 12 years and has had minimal issues. I'm not trying to get you on the defensive, I want to solve the issue here; best practice does dictate that the UI shouldn't be calling traces, so I'll move it into the slower think instead, but I doubt that's the underlying problem.

@thegrb93
Copy link
Author

It's been reported over the years as being the conflict but I think everyone just ended up uninstalling utime as the solution instead of reporting it.

GM:Think isn't slower, idk why you called it slower, but that is the only thing in utime I could find that had any pertinence to game physics/entity logic.

@thegrb93
Copy link
Author

You can see they date back to 2016 CapsAdmin/pac3#250 and CapsAdmin/pac3#300

@Nayruden
Copy link
Member

We called it slower so there wouldn't be performance issues and because users generally don't care about a 0.5-second delay.

@thegrb93
Copy link
Author

thegrb93 commented Jul 12, 2019

Oh I misunderstood, you plan on calling it less but still in the Panel:Think. I thought you were saying GM:Think was slower. You should try moving it to GM:Think. Different hook contexts can lead to different behavior in gmod. Yeah it would be a garrysmod bug, but neither we nor they can/will do anything about it.

@samcadams
Copy link

Would be amazing if this could be solved without outright removing utime

@thegrb93
Copy link
Author

@FIRES1 see if this version helps at all https://github.com/thegrb93/utime/tree/patch-1

@thegrb93
Copy link
Author

thegrb93 commented Jul 25, 2019

@FIRES1 any luck with the fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants