-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pac3 outfits lag behind with utime installed #7
Comments
Thanks, we'll keep this open as a record of the conflict. |
Fixed the title. Fyi, the issue seems to be from doing traces within the Panel:Think, perhaps if that was moved to Gamemode;Think, it might be fixed. Idk though |
You also ought to add a bug label. |
We use the bug label to signal a bug in the codebase hosting the issue tracker. Why do you think the trace is the cause of the conflict? UTime has been tested under a variety of conditions for 12 years and has had minimal issues. I'm not trying to get you on the defensive, I want to solve the issue here; best practice does dictate that the UI shouldn't be calling traces, so I'll move it into the slower think instead, but I doubt that's the underlying problem. |
It's been reported over the years as being the conflict but I think everyone just ended up uninstalling utime as the solution instead of reporting it. GM:Think isn't slower, idk why you called it slower, but that is the only thing in utime I could find that had any pertinence to game physics/entity logic. |
You can see they date back to 2016 CapsAdmin/pac3#250 and CapsAdmin/pac3#300 |
We called it slower so there wouldn't be performance issues and because users generally don't care about a 0.5-second delay. |
Oh I misunderstood, you plan on calling it less but still in the Panel:Think. I thought you were saying GM:Think was slower. You should try moving it to GM:Think. Different hook contexts can lead to different behavior in gmod. Yeah it would be a garrysmod bug, but neither we nor they can/will do anything about it. |
Would be amazing if this could be solved without outright removing utime |
@FIRES1 see if this version helps at all https://github.com/thegrb93/utime/tree/patch-1 |
@FIRES1 any luck with the fix? |
CapsAdmin/pac3#767
The text was updated successfully, but these errors were encountered: