Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Specific password requirements not included in validation in PasswordResetHandler #101

Open
lgratrix-techempower opened this issue Nov 16, 2020 · 0 comments

Comments

@lgratrix-techempower
Copy link

BasicSecurity.constructPasswordRequirements expects that it will be overwritten by applications in their extension of it. These requirements are enforced when calling BasicSecurity.passwordChange. However, in PasswordResetHandler.authorize the input is validated through getPasswordResetValidatorSet() process, which doesn't consider the application specific requirements. PasswordResetHandler.authorize allows those passwords that pass the default validation but would fail the application specific ones to make it past the validation step, but when it comes time to actually save, the password will fail. There is no failure indicated back to the caller here, so the user believes they have updated their password when they haven't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant