Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LaunchWrapper's logger config is being used on 1.7.10 and 1.12.2 #350

Open
makamys opened this issue Mar 19, 2024 · 1 comment
Open

LaunchWrapper's logger config is being used on 1.7.10 and 1.12.2 #350

makamys opened this issue Mar 19, 2024 · 1 comment
Labels

Comments

@makamys
Copy link

makamys commented Mar 19, 2024

(And probably other versions too, but I only checked these two.)

On 1.7.10 and 1.12.2, the logger config (log4j2.xml) can be found in three jars on the classpath: launchwrapper-1.12.jar, modpack.jar, minecraft.jar. They are in that order. And because they are in that order, the one in LaunchWrapper gets chosen, which is a fairly minimal one based on the vanilla one.

I'm not sure if this is intentional. For modded Minecraft, I consider Forge's config (1.7.10 | 1.12.2) (found within modpack.jar) more suitable since it includes debug messages, which are often invaluable for diagnosing issues.

For reference, the Forge jar comes first on the classpath with MultiMC-based launchers, the vanilla launcher (and by extension the CurseForge launcher), and ATLauncher, although all but the first override the config with the vanilla one using the log4j.configurationFile system property (for CurseForge this can be disabled).

I discovered the issue in The 1.7.10 Pack, but I was able to reproduce it in empty forge 1.7.10 and empty forge 1.12.2 as well.

Copy link

This issue is stale because it has been open for 90 days with no activity.

@github-actions github-actions bot added the stale Inactive issue label Jun 18, 2024
@Pyker Pyker added bug Priority: Low Low priority and removed stale Inactive issue labels Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants