Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project-music-releases-vite-estefanny #112

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

FannyEste
Copy link

@JennieDalgren JennieDalgren self-assigned this Oct 17, 2024
Copy link

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job with the project! You've met all requirements 🎊

Good job with comments in your code, splitting up into components, passing props, creating helper function for formatting the artists and making the site responsive!

You've done a great job separating concerns into different components (Album.jsx, ArtistName.jsx, etc.). This makes the code more maintainable and easier to understand.
Each component has a single responsibility, which aligns with best practices in React development.

Stay golden ⭐

import data from "./data.json";
import Album from './Album.jsx';

console.log(data);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this console.log before handing in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants