Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let users change their own address and/or email #194

Open
filiptypjeu opened this issue Jan 14, 2024 · 7 comments
Open

Let users change their own address and/or email #194

filiptypjeu opened this issue Jan 14, 2024 · 7 comments
Assignees

Comments

@filiptypjeu
Copy link
Member

No description provided.

@djstockma
Copy link
Contributor

Provide a page for users to edit their own personal information. Fields that users could change themselves include:

  • Gatuaddress
  • Postnummer
  • Postanstalt
  • Land
  • Telefonnummer
  • Epost
  • Vill ha modulen hemskickad (alternatively this could be done as a separate function: prenumerera / avprenumerera på modulen, but I think e checkbox works fine
  • Studentbladet (same as modulen, if this is even relevant?)

@tlangens
Copy link
Contributor

tlangens commented Mar 5, 2024

Note that before we allow this, there ought to be thorough validation in place, i.e. ensuring that the address is valid and exists. It has apparently been problematic before that people have changed their contact information incorrectly and so mail has been incorrectly delivered for years until the error was noticed.

@filiptypjeu
Copy link
Member Author

Sounds to me like the user's own problem if he updates his email to a faulty one... Faulty emails can slip through in the current process as well, but most faulty emails are old university domain emails that people have lost access to.

@filiptypjeu
Copy link
Member Author

I see now that you were talking about mail, not email, but my reasoning still applies.

@tlangens
Copy link
Contributor

tlangens commented Mar 5, 2024

IIRC there was some valid reasoning why we wanted the address changes to pass through human validation before being stored in the DB, so better check with Kansliet to get all the requirements sorted out first.
I think it would be in TF:s interest to prevent incorrect addresses in the registry as much as possible, as errors there might not be noticed for a long time or maybe ever. Unless it's too much hassle we might use e.g. Google's address validation API in the client before submitting the result.

@tlangens
Copy link
Contributor

tlangens commented Mar 5, 2024

Another thing worth considering might be storing history, so we can see what addresses people have used earlier.
One issue that I think we used to have was that as people updated certain fields like email, they would leave others empty, which in turn erased those values from the DB. That is probably more the fault of a bad client implementation though.

@djstockma
Copy link
Contributor

I checked with kansliet and they see no specific reason that this wouldn't be possible. Some type of validations for addresses (street and email) would definitely be good, but right now changes made to addresses etc (submitted by a form) aren't checked very closely either.

@filiptypjeu filiptypjeu self-assigned this Sep 21, 2024
filiptypjeu added a commit that referenced this issue Sep 22, 2024
… own profile page. This partly resolves issue #194, if not completely.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants