Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content search #77

Merged
merged 11 commits into from
Oct 2, 2024
Merged

Content search #77

merged 11 commits into from
Oct 2, 2024

Conversation

johan-lindell
Copy link
Contributor

@johan-lindell johan-lindell commented Sep 9, 2024 •
edited
Loading

Content and file search functionality.

  • File search is only available in private since there is no easy way to search all files within drive folder (that I found), since drive private API can get global access it is possible to do global file search. I think easiest way to get a public search would be to use different workspaces.

@backjonas backjonas linked an issue Sep 12, 2024 that may be closed by this pull request
Implement search functionality #71
Closed
@backjonas
Copy link
Member

Since we don't implement any ranking of results early suggestions will often contain the same results ordered alphabetically, should the suggestions that are shown when searching only query page / section titles?
Should also make the queries a bit lighter, but not sure if this difference is relevant.

Complete results could then be shown on a separate /search page, which could also implement the allow the optional file search

@johan-lindell johan-lindell force-pushed the content_search branch 3 times, most recently from 993fbde to 2062553 Compare September 15, 2024 12:38
backjonas
backjonas reviewed Sep 15, 2024
View reviewed changes
lib/strapi/search.ts Outdated Show resolved Hide resolved
backjonas
backjonas approved these changes Sep 15, 2024
View reviewed changes
Copy link
Member

@backjonas backjonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@johan-lindell johan-lindell changed the title DRAFT: Content search Content search Sep 17, 2024
@johan-lindell johan-lindell marked this pull request as ready for review September 17, 2024 18:27
marnym
marnym reviewed Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@marnym marnym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

I added some suggestions on how state could be handled better.

components/header/navbar/index.tsx Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
lib/strapi/search.ts Outdated Show resolved Hide resolved
lib/strapi/search.ts Outdated Show resolved Hide resolved
components/header/navbar/searchpage/index.tsx Outdated Show resolved Hide resolved
components/header/navbar/searchpage/index.tsx Outdated Show resolved Hide resolved
components/header/navbar/searchpage/index.tsx Outdated Show resolved Hide resolved
components/header/navbar/searchpage/index.tsx Outdated Show resolved Hide resolved
components/header/navbar/searchpage/SearchBar.tsx Outdated Show resolved Hide resolved
components/header/navbar/searchpage/index.tsx Outdated Show resolved Hide resolved
@johan-lindell johan-lindell force-pushed the content_search branch 4 times, most recently from 4ea75ca to 5baf52d Compare September 23, 2024 18:25
marnym
marnym requested changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@marnym marnym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please just fix the few comments and then we're good to go.

components/header/navbar/index.tsx Outdated Show resolved Hide resolved
components/header/navbar/searchpage/index.tsx Outdated Show resolved Hide resolved
components/header/navbar/searchpage/index.tsx Outdated Show resolved Hide resolved
components/header/navbar/searchpage/index.tsx Outdated Show resolved Hide resolved
@johan-lindell johan-lindell force-pushed the content_search branch 2 times, most recently from 9a56fee to f298f33 Compare October 2, 2024 09:25
@johan-lindell johan-lindell merged commit b9e6bc2 into master Oct 2, 2024
3 checks passed
@johan-lindell johan-lindell deleted the content_search branch October 2, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@backjonas backjonas backjonas approved these changes

@marnym marnym marnym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement search functionality
3 participants
@johan-lindell @backjonas @marnym