Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subtitle color changed in lists #343

Closed
wants to merge 5 commits into from
Closed

Subtitle color changed in lists #343

wants to merge 5 commits into from

Conversation

yceballost
Copy link
Contributor

@yceballost yceballost commented Mar 11, 2024 •
edited by amegias
Loading

🎟️ Jira ticket

https://jira.tid.es/browse/IOS-9929

🥅 What's the goal?

🚧 How do we do it?

🧪 How can I verify this?

🏑 AppCenter build

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 11, 2024 •
edited
Loading

Screenshot tests report

✔️ All passing

@aweell aweell mentioned this pull request Mar 20, 2024
Closed
6 tasks
@amegias
Copy link
Contributor

amegias commented Mar 26, 2024

Let us check this new feature:
https://github.com/Telefonica/mistica-ios/blob/main/CONTRIBUTING.md#record-new-snapshot-testing-reference-screenshots-for-a-pr
#342

@amegias
Copy link
Contributor

amegias commented Mar 26, 2024

/record-screenshots

@amegias
Copy link
Contributor

amegias commented Mar 26, 2024 •
edited
Loading

Let us check this new feature: https://github.com/Telefonica/mistica-ios/blob/main/CONTRIBUTING.md#record-new-snapshot-testing-reference-screenshots-for-a-pr #342

@franciscojrp we need to review this.
Yayo changed the subtitles and I've executed /record-screenshots.
The screenshots were re-recorded (196d56b) but:

amegias
amegias reviewed Mar 26, 2024
View reviewed changes
Sources/Mistica/Components/Lists/Internals/CellCenterSectionView.swift
didSet {
subtitleLabel.textColor = subtitleTextColor
detailLabel.textColor = subtitleTextColor
Copy link
Contributor

@amegias amegias Mar 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we were using the same color for both labels => wrong (it affected the UIKit component)

@amegias
Copy link
Contributor

amegias commented Mar 26, 2024

/record-screenshots

@franciscojrp
Copy link
Member

Let us check this new feature: https://github.com/Telefonica/mistica-ios/blob/main/CONTRIBUTING.md#record-new-snapshot-testing-reference-screenshots-for-a-pr #342

@franciscojrp we need to review this. Yayo changed the subtitles and I've executed /record-screenshots. The screenshots were re-recorded (196d56b) but:

  • one test still failed => ???

The testTabBarControl test seems to be the problem, we have previously seen it fail in another PR, and we did not see the cause, but if it keeps failing for every PR we need to review it

  • the PR should be updated showing ONLY one test failed, shouldn't it?

Good point, we need to change that if possible

This is pretty weird, let's see what happens with this comment

@yceballost yceballost marked this pull request as ready for review March 27, 2024 10:22
@amegias
Copy link
Contributor

amegias commented Apr 5, 2024

/record-screenshots

@amegias
Copy link
Contributor

amegias commented Jun 3, 2024

@yceballost Could we continue here #371 please?

@yceballost
Copy link
Contributor Author

@yceballost Could we continue here #371 please?

sure! Close this PR! Thanks 🫶

@amegias amegias closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amegias amegias amegias left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yceballost @amegias @franciscojrp