feat(DataCard): LATCH-1334 Now DataCard allows color customization #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Screenshot tests report ✔️ All passing |
salavert
commented
Mar 19, 2024
There was a problem hiding this comment.
It seems the cross now has the correct color
franciscojrp
approved these changes
Mar 19, 2024
tuentisre
pushed a commit
that referenced
this pull request
Mar 19, 2024
# [29.6.0](v29.5.1...v29.6.0) (2024-03-19) ### Features * **DataCard:** LATCH-1334 Now DataCard allows color customization ([#345](#345)) ([49bdb8e](49bdb8e))
|
🎉 This PR is included in version 29.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Jira ticket
LATCH-1334 DataCard with custom colors
🥅 What's the goal?
Android can customize the componer via modifier so we need to allow DataCard colors to be modified.
🚧 How do we do it?
Introduced property DataCardColorsConfiguration with default colors so no change will be needed when you update Mistica
🧪 How can I verify this?
RPReplay_Final1710839660.mov