Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback icons for O2 new #374

Merged
merged 5 commits into from
Jun 27, 2024
Merged

Feedback icons for O2 new #374

merged 5 commits into from
Jun 27, 2024

Conversation

yceballost
Copy link
Contributor

@yceballost yceballost commented Jun 21, 2024 •
edited
Loading

🎟️ Jira ticket

IOS-10333

🥅 What's the goal?

Replace custom animation assets for O2-New skin

🧪 How can I verify this?

Checkout screenshots in Files changed!

🏑 AppCenter build

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 21, 2024 •
edited
Loading

Screenshot tests report

✔️ All passing

@yceballost
Copy link
Contributor Author

yceballost commented Jun 21, 2024 •
edited by github-actions bot
Loading

Record screenshots on PR comment: succeeded ✅
https://github.com/Telefonica/mistica-ios/actions/runs/9614265983

@yceballost yceballost marked this pull request as ready for review June 21, 2024 14:09
@yceballost yceballost requested a review from amegias June 21, 2024 14:09
@amegias amegias requested review from a team and idenjoe and removed request for a team June 25, 2024 07:19
amegias
amegias approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@amegias amegias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested on o2New brand (it affects only this brand)

@amegias amegias merged commit 76ce0ce into main Jun 27, 2024
2 checks passed
@amegias amegias deleted the iceballos-o2New-feeback-icons branch June 27, 2024 06:55
tuentisre pushed a commit that referenced this pull request Jun 27, 2024
@semantic-release-bot
chore(release): 30.4.0 [skip ci]
05175c2 
# [30.4.0](v30.3.0...v30.4.0) (2024-06-27)

### Features

* **Accesibility:** Accesibility of Snackbars and croutons ([#375](#375)) ([21bf939](21bf939))
* **Feedback:** Feedback icons for O2 new ([#374](#374)) ([76ce0ce](76ce0ce))
@tuentisre
Copy link
Collaborator

🎉 This PR is included in version 30.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@yceballost yceballost linked an issue Jul 1, 2024 that may be closed by this pull request
Update lottie animations for o2 Telefonica/mistica-design#1806
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amegias amegias amegias approved these changes

@idenjoe idenjoe idenjoe approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update lottie animations for o2
4 participants
@yceballost @tuentisre @idenjoe @amegias