Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow GET_UNSEEN_NOTIFICATIONS_BADGE undefined payload #176

Open
kydorn opened this issue Nov 28, 2024 · 0 comments
Open

Allow GET_UNSEEN_NOTIFICATIONS_BADGE undefined payload #176

kydorn opened this issue Nov 28, 2024 · 0 comments

Comments

@kydorn
Copy link

kydorn commented Nov 28, 2024

In some cases in which the native implementation does not have a current value for the unseen notifications badge (when it has not checked the current value yet or it has not been set by other means), the apps will send the response with no payload.

We need the GET_UNSEEN_NOTIFICATIONS_BADGE method to support responses without payload.

Also,the exported method:
getUnseenNotificationsBadge: () => Promise<{unseenNotificationCounter: number; lastUpdated: number}>;
would need to change to something like:
getUnseenNotificationsBadge: () => Promise<{unseenNotificationCounter: number; lastUpdated: number} | void>;

@kydorn kydorn changed the title Allow GET_UNSEEN_NOTIFICATIONS_BADGE empty payload Allow GET_UNSEEN_NOTIFICATIONS_BADGE undefined payload Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant