Discussion: CPU features

[Tinyblargon]

Currently the qemu resource of the provider has a lot of top level keys.
We are no where near all the features we want to support for this resource.
The problem is that some keys are already in use for other things.

For example the cpu key is used for setting the CPU type.
This also means we have multiple CPU related keys.
All these keys aren't prefixed with cpu_ making it unclear what they do.

• cpu
• sockets
• cores
• vcpus
• numa

This means that for CPU limit, CPU Affinity, CPU units and Extra CPU Flags we would have to add more top level keys.

Currently I have 2 proposals.

Proposal one

Deprecate all CPU related flags and introduce the following schema:

resource "proxmox_vm_qemu" "one" {
  cpu_type = "host"
  cpu_cores = 2
  cpu_sockets = 1
  cpu_vcores = 2
  cpu_numa = true
  cpu_limit = 64
  cpu_affinity = "1-3,5"
  cpu_units = 1024
  cpu_flags = "+aes,-avx"
}

Proposal two

Deprecate all CPU related flags, repurpose the cpu key and introduce the following schema:

resource "proxmox_vm_qemu" "two" {
  cpu {
    type = "host"
    cores = 2
    sockets = 1
    vcores = 2
    numa = true
    limit = 64
    affinity = "1-3,5"
    units = 1024
    flags {
      md_clear = "on"
      pcid = "off"
      spec_ctrl = "default"
      ssbd = "default"
      ibpb = "on"
      virt_ssbd = "on"
      amd_ssbd = "off"
      amd_no_ssb = "off"
      pbpe1gb = "off"
      hv_tlbflush = "on"
      hv_evmcs = "on"
      aes = "defualt"
    }
  }

This would force all CPU related information to be near one another.
I'm not sure how usable a nested schema like this would be for modules.

[maksimsamt]

my vote for "Proposal two"

[den-patrakeev]

my vote for "Proposal two"