From db9a6a9033ec3ef05bdc686ebdb8f03d66e8585e Mon Sep 17 00:00:00 2001
From: Antonio <firstcya@gmail.com>
Date: Mon, 27 Nov 2023 17:25:11 +0800
Subject: [PATCH] feat: Support screen orientation in plugin's AndroidManifest

---
 .../sample-app/src/main/AndroidManifest.xml            |  1 +
 .../core/loader/delegates/ShadowActivityDelegate.kt    |  3 +++
 .../shadow/core/manifest_parser/AndroidManifestKeys.kt |  1 +
 .../core/manifest_parser/AndroidManifestReader.kt      |  1 +
 .../core/manifest_parser/PluginManifestGenerator.kt    | 10 ++++++++--
 .../tencent/shadow/core/runtime/PluginManifest.java    |  7 ++++++-
 6 files changed, 20 insertions(+), 3 deletions(-)

diff --git a/projects/sample/source/sample-plugin/sample-app/src/main/AndroidManifest.xml b/projects/sample/source/sample-plugin/sample-app/src/main/AndroidManifest.xml
index abac57e88..2d20257c4 100644
--- a/projects/sample/source/sample-plugin/sample-app/src/main/AndroidManifest.xml
+++ b/projects/sample/source/sample-plugin/sample-app/src/main/AndroidManifest.xml
@@ -24,6 +24,7 @@
         <activity
             android:name="com.tencent.shadow.sample.plugin.app.lib.usecases.activity.TestActivityOrientation"
             android:configChanges="orientation|screenSize|fontScale"
+            android:screenOrientation="landscape"
             android:windowSoftInputMode="adjustResize" />
 
         <activity
diff --git a/projects/sdk/core/loader/src/main/kotlin/com/tencent/shadow/core/loader/delegates/ShadowActivityDelegate.kt b/projects/sdk/core/loader/src/main/kotlin/com/tencent/shadow/core/loader/delegates/ShadowActivityDelegate.kt
index 05a5d254e..8652587d1 100644
--- a/projects/sdk/core/loader/src/main/kotlin/com/tencent/shadow/core/loader/delegates/ShadowActivityDelegate.kt
+++ b/projects/sdk/core/loader/src/main/kotlin/com/tencent/shadow/core/loader/delegates/ShadowActivityDelegate.kt
@@ -188,6 +188,9 @@ open class ShadowActivityDelegate(private val mDI: DI) : GeneratedShadowActivity
             pluginActivity.applicationInfo.theme
         }
         pluginActivity.setTheme(activityTheme)
+        if (pluginActivityInfo.screenOrientation != ActivityInfo.SCREEN_ORIENTATION_UNSPECIFIED && pluginActivityInfo.screenOrientation != pluginActivity.requestedOrientation) {
+            pluginActivity.requestedOrientation = pluginActivityInfo.screenOrientation
+        }
     }
 
     override fun getLoaderVersion() = BuildConfig.VERSION_NAME
diff --git a/projects/sdk/core/manifest-parser/src/main/kotlin/com/tencent/shadow/core/manifest_parser/AndroidManifestKeys.kt b/projects/sdk/core/manifest-parser/src/main/kotlin/com/tencent/shadow/core/manifest_parser/AndroidManifestKeys.kt
index dee8e4f4e..21cf09bc5 100644
--- a/projects/sdk/core/manifest-parser/src/main/kotlin/com/tencent/shadow/core/manifest_parser/AndroidManifestKeys.kt
+++ b/projects/sdk/core/manifest-parser/src/main/kotlin/com/tencent/shadow/core/manifest_parser/AndroidManifestKeys.kt
@@ -7,6 +7,7 @@ sealed class AndroidManifestKeys {
         const val name = "android:name"
         const val theme = "android:theme"
         const val configChanges = "android:configChanges"
+        const val screenOrientation = "android:screenOrientation"
         const val windowSoftInputMode = "android:windowSoftInputMode"
         const val authorities = "android:authorities"
         const val `intent-filter` = "intent-filter"
diff --git a/projects/sdk/core/manifest-parser/src/main/kotlin/com/tencent/shadow/core/manifest_parser/AndroidManifestReader.kt b/projects/sdk/core/manifest-parser/src/main/kotlin/com/tencent/shadow/core/manifest_parser/AndroidManifestReader.kt
index ee94146cb..82e8039b5 100644
--- a/projects/sdk/core/manifest-parser/src/main/kotlin/com/tencent/shadow/core/manifest_parser/AndroidManifestReader.kt
+++ b/projects/sdk/core/manifest-parser/src/main/kotlin/com/tencent/shadow/core/manifest_parser/AndroidManifestReader.kt
@@ -114,6 +114,7 @@ class AndroidManifestReader {
             AndroidManifestKeys.theme,
             AndroidManifestKeys.configChanges,
             AndroidManifestKeys.windowSoftInputMode,
+            AndroidManifestKeys.screenOrientation,
         ).forEach { attributeKey ->
             activityMap.putAttributeIfNotNull(element, attributeKey)
         }
diff --git a/projects/sdk/core/manifest-parser/src/main/kotlin/com/tencent/shadow/core/manifest_parser/PluginManifestGenerator.kt b/projects/sdk/core/manifest-parser/src/main/kotlin/com/tencent/shadow/core/manifest_parser/PluginManifestGenerator.kt
index b6a7c5b8a..0a84018c3 100644
--- a/projects/sdk/core/manifest-parser/src/main/kotlin/com/tencent/shadow/core/manifest_parser/PluginManifestGenerator.kt
+++ b/projects/sdk/core/manifest-parser/src/main/kotlin/com/tencent/shadow/core/manifest_parser/PluginManifestGenerator.kt
@@ -183,13 +183,14 @@ private class PluginManifestBuilder(val manifestMap: ManifestMap) {
     private fun toNewActivityInfo(componentMap: ComponentMap): String {
         fun makeResIdLiteral(
             key: String,
+            defaultValue: String = "0",
             valueToResId: (value: String) -> String
         ): String {
             val value = componentMap[key] as String?
             val literal = if (value != null) {
                 valueToResId(value)
             } else {
-                "0"
+                defaultValue
             }
             return literal
         }
@@ -204,12 +205,17 @@ private class PluginManifestBuilder(val manifestMap: ManifestMap) {
             it
         }
 
+        val screenOrientation = makeResIdLiteral(AndroidManifestKeys.screenOrientation, "-1") {
+            it
+        }
+
         return "new com.tencent.shadow.core.runtime.PluginManifest" +
                 ".ActivityInfo(" +
                 "\"${componentMap[AndroidManifestKeys.name]}\", " +
                 "$themeLiteral ," +
                 "$configChangesLiteral ," +
-                softInputModeLiteral +
+                "$softInputModeLiteral ," +
+                screenOrientation +
                 ")"
     }
 
diff --git a/projects/sdk/core/runtime/src/main/java/com/tencent/shadow/core/runtime/PluginManifest.java b/projects/sdk/core/runtime/src/main/java/com/tencent/shadow/core/runtime/PluginManifest.java
index 67f8a31c0..f8acdf7ea 100644
--- a/projects/sdk/core/runtime/src/main/java/com/tencent/shadow/core/runtime/PluginManifest.java
+++ b/projects/sdk/core/runtime/src/main/java/com/tencent/shadow/core/runtime/PluginManifest.java
@@ -70,15 +70,18 @@ final class ActivityInfo extends ComponentInfo implements Parcelable {
         public final int theme;
         public final int configChanges;
         public final int softInputMode;
+        public final int screenOrientation;
 
         public ActivityInfo(String className,
                             int theme,
                             int configChanges,
-                            int softInputMode) {
+                            int softInputMode,
+                            int screenOrientation) {
             super(className);
             this.theme = theme;
             this.configChanges = configChanges;
             this.softInputMode = softInputMode;
+            this.screenOrientation = screenOrientation;
         }
 
         protected ActivityInfo(Parcel in) {
@@ -86,6 +89,7 @@ protected ActivityInfo(Parcel in) {
             theme = in.readInt();
             configChanges = in.readInt();
             softInputMode = in.readInt();
+            screenOrientation = in.readInt();
         }
 
         @Override
@@ -94,6 +98,7 @@ public void writeToParcel(Parcel dest, int flags) {
             dest.writeInt(theme);
             dest.writeInt(configChanges);
             dest.writeInt(softInputMode);
+            dest.writeInt(screenOrientation);
         }
 
         @Override