refactor: image组件演示代码拆分 #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Luozf12345
reviewed
Jul 31, 2024
| margin: const EdgeInsets.all(8), | ||
| child: CodeWrapper( | ||
| builder: _imageClip, | ||
| methodName: '_imageClip', // 裁剪 |
Luozf12345
reviewed
Jul 31, 2024
| Padding( | ||
| padding: const EdgeInsets.only(bottom: 16), | ||
| child: TDText( | ||
| '裁剪', |
There was a problem hiding this comment.
这个描述如果挪到实例方法外面，此处只生成图片范围的示例代码会更好
There was a problem hiding this comment.
感谢指出，能get到你的点，这里的示例代码只展示了图片范围部分，用户查看的时候不会看到无关的代码。而项目代码中关于Padding的描述和图片组件是一个整体，感觉不太好单独拎出来。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
#207
💡 需求背景和解决方案
Image的“组件类型”和“组件状态”下面，多个演示组件使用同一份演示代码，演示代码太长，可读性不高
📝 更新日志
refactor(image): 将Image组件的演示代码进行拆分，使其查阅起来更直观简单。同时对组件的排列方式进行了调整，将同类组件放在一行，提高文档易读性。
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单