Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(td_count_down): 添加正向计时功能 #246

Merged
merged 5 commits into from
Aug 2, 2024

Conversation

epoll-j
Copy link
Contributor

@epoll-j epoll-j commented Jul 23, 2024

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交x
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#189

💡 需求背景和解决方案

📝 更新日志

倒计时组件增加正向计时功能,通过direction参数控制

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • Changelog 已提供或无须提供

@tencent-adm
Copy link
Member

tencent-adm commented Jul 23, 2024

CLA assistant check
All committers have signed the CLA.

@Luozf12345
Copy link
Collaborator

您好,感谢您的贡献。对于正向计时的问题,我们内部讨论的方案,是需要把CountDown组件名称更新为TimeCounter,参数的实现可以与当前保持一致,麻烦把涉及组件名称的代码修改一致(api和示例代码的资源文档可以通过脚本自动生成,修改代码一致即可)。再次感谢您的贡献~

@epoll-j
Copy link
Contributor Author

epoll-j commented Jul 27, 2024

您好,感谢您的贡献。对于正向计时的问题,我们内部讨论的方案,是需要把CountDown组件名称更新为TimeCounter,参数的实现可以与当前保持一致,麻烦把涉及组件名称的代码修改一致(api和示例代码的资源文档可以通过脚本自动生成,修改代码一致即可)。再次感谢您的贡献~

涉及CountDown组件名称的代码已修改完

@Luozf12345 Luozf12345 merged commit 18d4937 into Tencent:develop Aug 2, 2024
2 checks passed
@github-actions github-actions bot mentioned this pull request Oct 15, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants