Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TagInput] 扩展 collapsedItems 的删除功能 #3662

Closed
topazur opened this issue Nov 30, 2023 · 3 comments
Closed

[TagInput] 扩展 collapsedItems 的删除功能 #3662

topazur opened this issue Nov 30, 2023 · 3 comments
Assignees
@chaishi @PengYYYYY
Labels
to be published to be published

Comments

@topazur
Copy link
Contributor

topazur commented Nov 30, 2023

这个功能解决了什么问题

  1. 统一 collapsedItems 的类型定义 （为什么只需要 value 和 onClose？其他属性都可以在外部拿到，且 onClose 仅需要 event 和 index 参数即可）
  2. 统一文档及示例交互形式。
  3. 涉及UI/交互变动需要有截图或 GIF。
image

你建议的方案是什么

Tencent/tdesign-react#2630
@github-actions GitHub Actions
Copy link
Contributor

👋 @topazur，感谢给 TDesign 提出了 issue。
请根据 issue 模版确保背景信息的完善，我们将调查并尽快回复你。

@github-actions GitHub Actions
Copy link
Contributor

♥️ 有劳 @chaishi @PengYYYYY 尽快确认问题。
确认有效后将下一步计划和可能需要的时间回复给 @topazur 。

topazur added a commit to topazur/tdesign-vue-next-repo that referenced this issue Nov 30, 2023
@topazur
feat(TagInput): expand the deletion function of collapsedItems(Tencen…
32cf5c4 
…t#3662)
@topazur topazur mentioned this issue Nov 30, 2023
Merged
16 tasks
@topazur
Copy link
Contributor Author

topazur commented Nov 30, 2023

在改造过程中发现了 TreeSelect 的bug

image
  • 觉得 watch 这里的问题
image

topazur added a commit to topazur/tdesign-vue-next-repo that referenced this issue Dec 1, 2023
@topazur
docs(Select/TreeSelect): update example file(Tencent#3662)
1ebe123
topazur added a commit to topazur/tdesign-vue-next-repo that referenced this issue Dec 1, 2023
@topazur
fix(TagInput): onClose parameter(Tencent#3662)
779a06e
@uyarn uyarn added to be published to be published 🏃 in progress someone is developing and removed to be published to be published labels Dec 2, 2023
@uyarn uyarn added to be published to be published and removed 🏃 in progress someone is developing labels Mar 26, 2024
uyarn added a commit that referenced this issue Mar 26, 2024
@topazur @uyarn
feat(TagInput): expand the deletion function of collapsedItems(#3662) (…
2504697 
…#3663)

* feat(TagInput): expand the deletion function of collapsedItems(#3662)

* docs(Select/TreeSelect): update example file(#3662)

* fix(TagInput): onClose parameter(#3662)

* chore: update api

* chore: update api

* chore: update api

* chore: update api

* chore: update api

* chore: update snapshot

* chore: fix lint

* chore: update snapshot

---------

Co-authored-by: Uyarn <[email protected]>
@PengYYYYY PengYYYYY mentioned this issue Mar 28, 2024
Merged
16 tasks
@uyarn uyarn closed this as completed Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chaishi chaishi

@PengYYYYY PengYYYYY

Labels
to be published to be published
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chaishi @uyarn @PengYYYYY @topazur