Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the new "Concat" node to combine totally empty "T5 Text Encode" with normal "Clip Text Encode" gives WAY better results than actually using "T5 Text Encode", Lora or no Lora #24

Open
Akira13641 opened this issue Apr 23, 2024 · 3 comments

Comments

@Akira13641
Copy link

This setup:
image

created this image:
image

This setup:
image

created this image:
image

@Akira13641
Copy link
Author

So it seems like whatever concatting with empty "Clip Text Encode" does should just actually be what "T5 Text Encode" does internally by default, all the time, otherwise "T5 Text Encode" is worse no matter what

@JettHu
Copy link
Collaborator

JettHu commented Apr 24, 2024

ELLA is for comprehending dense prompts, encompassing multiple objects, detailed attributes, complex relationships, long-text alignment, etc. However, there is no guarantee that ELLA will bring better results in aesthetic scores.

whatever concatting with empty "Clip Text Encode" does should just actually be what "T5 Text Encode" does internally by default

The current design is to be more flexible usage. Thanks for the suggestion, I will consider adding a text encode, using both t5 and clip by default. But before doing this, t5 weighted prompt support need to be solved first (The prompt we give to clip will always have a weight).

@JettHu
Copy link
Collaborator

JettHu commented Apr 30, 2024

@Akira13641 I've add a ELLA Text Encode node to automatically concat ella and clip condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants