Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpmlint errors #473

Open
TimothyAsirJeyasing opened this issue Nov 9, 2017 · 2 comments
Open

rpmlint errors #473

TimothyAsirJeyasing opened this issue Nov 9, 2017 · 2 comments
Assignees

Comments

@TimothyAsirJeyasing
Copy link
Contributor

The following rpmlint errors are identified in 1.5.4 release:
tendrl-gluster-integration.noarch: E: zero-length /usr/lib/python2.7/site-packages/tendrl/gluster_integration/objects/base_object.py
tendrl-gluster-integration.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/tendrl/gluster_integration/sds_sync/vol_utilization.py 644 /usr/bin/python

tendrl-gluster-integration.noarch: W: incoherent-version-in-changelog 1.5.4-1 ['1.5.4-1.el7.centos', '1.5.4-1.centos']
tendrl-gluster-integration.noarch: W: non-etc-or-var-file-marked-as-conffile /usr/share/tendrl/gluster-integration/gluster-integration.conf.yaml
tendrl-gluster-integration.noarch: W: conffile-without-noreplace-flag /usr/share/tendrl/gluster-integration/gluster-integration.conf.yaml
tendrl-gluster-integration.noarch: W: no-manual-page-for-binary tendrl-gluster-vol-utilization
tendrl-gluster-integration.noarch: W: no-manual-page-for-binary tendrl-gluster-integration

Do we need this file: /usr/lib/python2.7/site-packages/tendrl/gluster_integration/objects/base_object.py which is empty

File: tendrl/gluster_integration/sds_sync/vol_utilization.py is it an executable file? If not we can remove shebang

@TimothyAsirJeyasing
Copy link
Contributor Author

Though most of the issues looks simple and harmless, we can not simply remove the file to fix rpmlint errors or we can not add shebang or remove executable permission or simply change the file permission at this point. It may affect the functionality of the program. We can do it slowly in a separate branch.

@r0h4n
Copy link
Contributor

r0h4n commented Nov 9, 2017

@TimothyAsirJeyasing Please fix them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants