Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser: remove waitForBugoutOnline #434

Open
3 tasks
Terkwood opened this issue Oct 28, 2020 · 0 comments
Open
3 tasks

Browser: remove waitForBugoutOnline #434

Terkwood opened this issue Oct 28, 2020 · 0 comments
Labels
tech-debt Lib upgrades, Carryover from prior decisions, &c

Comments

@Terkwood
Copy link
Owner

Terkwood commented Oct 28, 2020

  • We can remove the check for bugout to be online in gtp.js:
if (!this.gameId && this.entryMethod === EntryMethod.PLAY_BOT) {
          this.setupBotGame(this.botDifficulty);
        } else {
          // Until https://github.com/Terkwood/BUGOUT/issues/174
          // is completed, we need to wait for the system to
          // come online when we're playing against a human being.
          this.waitForBugoutOnline().then((a, b) => this.onBugoutOnline(a, b));
        }
  • We should remove logic based on idleStatus in MultiplayerColorPrefModal.
  • Make sure none of these changes break the gateway flow
@Terkwood Terkwood added the tech-debt Lib upgrades, Carryover from prior decisions, &c label Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Lib upgrades, Carryover from prior decisions, &c
Projects
None yet
Development

No branches or pull requests

1 participant