Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled element should not be focusable #1031

Open
Lb-lea opened this issue Nov 15, 2018 · 4 comments
Open

Disabled element should not be focusable #1031

Lb-lea opened this issue Nov 15, 2018 · 4 comments

Comments

@Lb-lea
Copy link

Lb-lea commented Nov 15, 2018

Hello,
I noticed that the previous/next button on the b:Datatable pagination were still focusable when they where disabled. It is usually common practice to prevent focus on disabled elements (and the bootstrap datatable does unfocus its disabled elements).
The answer is to tabindex="-1" these elements.

@stephanrauh
Copy link
Collaborator

stephanrauh commented Nov 16, 2018

Oops. You're right (like always!). However, I'm not sure if we can do something about this bug. It looks like a bug we've inherited from datatables.net, so their repository might be the right place to mention this bug. Plus, a cross-reference to us so we know when it's time to update our dependency from datatables.net.

However, this is only a first assessment. Maybe we can solve the bug ourselves easily.

Merci, et a bientôt
Stephan

@geopossachs
Copy link
Collaborator

geopossachs commented Sep 4, 2019

I would say this is a bug who is located in the third party library datatables.net

I take a look and would say this is the class there to change it
https://github.com/DataTables/DataTablesSrc/blob/master/js/ext/ext.paging.js

But we can open an issue in the third party library. DataTables/DataTablesSrc#146

@geopossachs
Copy link
Collaborator

fixed by commit DataTables/DataTablesSrc@33219ff - we are still wating on the next version of DataTables

@geopossachs geopossachs added this to the v1.5.0 milestone Sep 4, 2019
@stephanrauh
Copy link
Collaborator

Whow - it was fixed yesterday, and you've already found it! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants