Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI pipeline #31

Open
1 of 2 tasks
TheCodez opened this issue Apr 17, 2020 · 7 comments
Open
1 of 2 tasks

Add CI pipeline #31

TheCodez opened this issue Apr 17, 2020 · 7 comments

Comments

@TheCodez
Copy link
Owner

TheCodez commented Apr 17, 2020

  • Ubuntu building
  • Windows building
@TheCodez TheCodez mentioned this issue Apr 17, 2020
7 tasks
@TheCodez
Copy link
Owner Author

@cbachhuber not including the demo project in the build links successfully. So the problem should stem from the demo project.

@cbachhuber
Copy link
Contributor

Right, I already found that as well. I'm quite sure, however, that not the demo project is the problem, but that we are linking everything together to an executable. So at this time, 'undefined reference' errors will surface.

I had the suspicion that CI does not find the GLEW library, and I'm right:

  • I added printing of variable GLEW_LIBRARY in this commit.
  • On my machine, I see during configuration
    -- GLEW LIBRARY LOCATION: 
    -- /usr/lib/x86_64-linux-gnu/libGLEW.so
    
  • On CI, I see
     -- GLEW LIBRARY LOCATION: 
     --
    

So I'm currently looking into ways of enabling CI to find GLEW. Do you think that makes sense?

@cbachhuber
Copy link
Contributor

Fixed! See this build :)

@cbachhuber
Copy link
Contributor

This answer writes GLEW_LIBRARIES instead of GLEW_LIBRARY. Also cmake documentation promotes GLEW_LIBRARIES. So I used that, and it works :)

PR incoming ;)

@TheCodez
Copy link
Owner Author

TheCodez commented Apr 17, 2020

Thanks you for testing this. I just pushed a commit to see if GLEW_LIBRARIES is the only change needed.
So I guess no need for a PR but thanks a lot 👍
I just saw you also did some cleanup so a PR is fine of course.

@cbachhuber
Copy link
Contributor

It seems that something else is needed. I just created a new branch, but with only the GLEW_LIBRARIES change it does not compile. I suggest that I clean up branch fix-ci and create a PR. Ok?

@TheCodez
Copy link
Owner Author

Sure go ahead 👍 . I suggest rebasing against my master branch as I have removed the build folder. So it has to be created again in the CI.

This was referenced Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants