Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

Use SQLite instead of pickle for object handling #12

Open
viralpoetry opened this issue Jun 3, 2017 · 2 comments
Open

Use SQLite instead of pickle for object handling #12

viralpoetry opened this issue Jun 3, 2017 · 2 comments

Comments

@viralpoetry
Copy link

Krzysztof,
Thanks for sharing your source code! It's clean and easy to read.

Not sure whether you are still working on it, but I think it should be better to use some database for the objects, so some future API can use it as well. Hence I have created this issue.

@TheKysek
Copy link
Owner

TheKysek commented Jun 4, 2017

Thank you for your interest!

I was planning on changing the method of object sorage but it is not a high priority issue.
However I will definitely run some tests and do something about it at a later day.

@Lvl4Sword
Copy link

https://docs.python.org/3/library/pickle.html states

Warning

The pickle module is not secure against erroneous or maliciously constructed data. Never unpickle data received from an untrusted or unauthenticated source.

So I can understand why pickling is ill-advised 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants