Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show ads on certain pages #567

Open
kyxc opened this issue Feb 22, 2021 · 3 comments
Open

Don't show ads on certain pages #567

kyxc opened this issue Feb 22, 2021 · 3 comments
Labels
bug Issue reporting that an existing feature does not work as intended planned Issue that is (a candidate for) being worked on

Comments

@kyxc
Copy link

kyxc commented Feb 22, 2021

In the CMS, when inputting articles, there is an option to have ads not be displayed on the article (usually used for guest opinion articles and obituaries). I can deselect the option (see photo below), but it doesn't actually remove the ads on the webpage when the article gets published (see https://thetech.com/2021/02/18/merit-based-raises-hurt-dei). Would be good to fix this!
image

@bkettle bkettle added bug Issue reporting that an existing feature does not work as intended planned Issue that is (a candidate for) being worked on labels Mar 3, 2021
@CyanoKobalamyne
Copy link
Member

I can't reproduce this. There is no ad on that page at the moment, but there are ads on other OPN article pages that have that box checked. (E.g. https://thetech.com/2021/03/25/cloak-of-racism-op-ed)

@bkettle bkettle added bug Issue reporting that an existing feature does not work as intended planned Issue that is (a candidate for) being worked on and removed bug Issue reporting that an existing feature does not work as intended planned Issue that is (a candidate for) being worked on labels Sep 13, 2021
@bkettle
Copy link
Contributor

bkettle commented Sep 13, 2021

I see ads on both of these pages.

@CyanoKobalamyne
Copy link
Member

I'm pretty sure it was a caching issue. Some changes to articles propagate really slowly, and at different speeds to different views (e.g. some search previews keep showing old blurbs for days/weeks when they are updated). Maybe this should be investigated at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reporting that an existing feature does not work as intended planned Issue that is (a candidate for) being worked on
Projects
None yet
Development

No branches or pull requests

3 participants