Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running in proxy environment causes spinner #44

Open
databus23 opened this issue Nov 23, 2016 · 3 comments
Open

Running in proxy environment causes spinner #44

databus23 opened this issue Nov 23, 2016 · 3 comments

Comments

@databus23
Copy link

databus23 commented Nov 23, 2016

Trying to to access the corectl menu icon always gives a busy spinner in my corporate network.
We have a mandatory http(s)_proxy and no direct internet connectivity.
Seems like some hanging network call is blocking the UI thread, which is not good in general.

It works when I switch to a proxy-free internet-connected network.

Would be awesome if corectl could pick up the proxy from settings (not only static settings but also auto configured PAC-file based ones) for network calls.

@databus23
Copy link
Author

Seems like its the update checks. When I start it in a proxy-free environment it continues to work in a proxy environment until I hit "Check for udpates" or restart the app.

@urfuwo
Copy link

urfuwo commented Nov 23, 2016

+1

@databus23
Copy link
Author

Ok looking into this some more it seems like this comes from the shell scripts that are executed from the swift app.
When I add this snipplet to the top of some of the bash scripts the spinner goes away:

[ -f /usr/local/share/proxy_settings.sh ] && source /usr/local/share/proxy_settings.sh

I had to add it to the following files:

check_blobs_version.command
check_corectl_app_version.command
check_corectld_version.command
fetch_latest_iso_alpha.command
fetch_latest_iso_beta.command
fetch_latest_iso_stable.command
update_corectl_blobs.command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants