Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How about replacing the progress method? #23

Open
Lazyt3ch opened this issue Jan 15, 2023 · 2 comments
Open

How about replacing the progress method? #23

Lazyt3ch opened this issue Jan 15, 2023 · 2 comments

Comments

@Lazyt3ch
Copy link
Contributor

Lazyt3ch commented Jan 15, 2023

Hello,

Every time I run the tests on my machine or just look at the PROBLEMS tab in VS Code, I see the TS compiler's complaints caused by the use of the progress method of the when library.

The when library's API documentation recommends replacing progress with promise.tab. According to the history of changes, which was last updated on Dec. 24, 2015, the progress method was first deprecated in version 3.5.0, so it's quite outdated by now.

Perhaps it might be possible to replace progress with something else? I'm not sure it will be worth the trouble, though.

Regards,
Rashid

@TheTechsTech
Copy link
Owner

That is the problem with TS and the whole build issues around it. I don't use TS, that's a feature someone contributed and had those problems present when added then too.

Some things initially cause tests to fail, they fixed that, and I guess they still working on those TS issues.

You can try addressing them see if it doesn't break behavior of this package.

@Lazyt3ch
Copy link
Contributor Author

Thank you for explaining the situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants