Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to the API documentation #1301

Closed
Siva-7482 opened this issue Apr 6, 2024 · 1 comment · Fixed by #1308
Closed

Minor changes to the API documentation #1301

Siva-7482 opened this issue Apr 6, 2024 · 1 comment · Fixed by #1308
Assignees
Milestone

Comments

@Siva-7482
Copy link
Contributor

Summary

We have identified minor improvements in The Things Stack API documentation.

  1. Update the length of token-id and token-secret.
  2. Update the typo of the word perform.
  3. Update the URL references of messages.proto and lorawan.proto.
  4. Update The Things Stack Community Edition as The Things Stack Sandbox.

Why do we need this ?

To ensure the API documentation is up to date.

What is already there? What do you see now?

The Things Stack API documentation

What is missing? What do you want to see?

Update the API documentation for the recommended sections.

How do you propose to document this?

1. Update the length of token-id, and token-secret:

In the 'What are API Keys?' section, it is noted that there is a discrepancy in the length of the API Keys.image

The token-id length is mentioned as 24 characters, but it seems 39 characters long. Similarly, the token-secret length is mentioned as 32 characters, whereas it seems 52 characters in length.


2. Update the typo of the word perform:

The Authorization section contains a typo; perfrom should be corrected to perform. Please find the section here: Authorization Section

image

3. Update the URL references of messages.proto and lorawan.proto:

The URLs for messages.proto and lorawan.proto are broken, resulting in a 404 Not Found error when accessed. Please update the messages.proto and lorawan.proto with the correct URLs. Ref: LoRa Gateway MQTT

image


4. Update The Things Stack Community Edition as The Things Stack Sandbox:

In the errors section of the API documentation, we need to update The Things Stack Community Edition with The Things Stack Sandbox. Please find the reference here: Troubleshooting

image

Can you do this yourself and submit a Pull Request?

We do not have the references for the messages.proto and lorawan.proto. Hence, filed this issue instead of PR.

No, @nejraselimovic

@github-actions github-actions bot added the needs/triage We still need to triage this label Apr 6, 2024
@KrishnaIyer KrishnaIyer self-assigned this Apr 9, 2024
@KrishnaIyer KrishnaIyer removed the needs/triage We still need to triage this label Apr 9, 2024
@KrishnaIyer KrishnaIyer added this to the Apr 2024 milestone Apr 9, 2024
@KrishnaIyer
Copy link
Contributor

Covered in #1308
Next time @Siva-7482 please create a PR since you have all the required information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants