Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in LoRaWAN packet diagram #555

Open
simonarnell opened this issue Aug 9, 2024 · 0 comments
Open

Typo in LoRaWAN packet diagram #555

simonarnell opened this issue Aug 9, 2024 · 0 comments

Comments

@simonarnell
Copy link

Summary

To correct a typo in the LoRaWAN uplink packet diagram.

Why do we need this ?

To correctly reflect the LoRaWAN specification.

What is already there? What do you see now?

There are currently two fields labelled as Preamble.

What is missing? What do you want to see?

The second instance of the Preamble field should be labelled PHYPayload.

How do you propose to document this?

Requires an edit of the PNG file, otherwise I would have edited an SVG directly.

Can you do this yourself and submit a Pull Request?

No as presently images are stored as PNGs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant