Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply a default pagination on IS List RPCs if not provided in the request #7327

Closed
2 of 6 tasks
KrishnaIyer opened this issue Oct 8, 2024 · 1 comment
Closed
2 of 6 tasks
Assignees
Labels
bug Something isn't working c/identity server This is related to the Identity Server needs/testing This needs to be tested on staging
Milestone

Comments

@KrishnaIyer
Copy link
Member

Summary

Apply a default pagination on IS List RPCs if not provided in the request.

Steps to Reproduce

  1. List end devices in an application or all gateways of a user.
  2. Don't set the Limit field of the request.

Current Result

Currently limit value of 0 returns all entries.

Expected Result

We should use a default value and use that when the limit in the request is not set.

Relevant Logs

No response

URL

No response

Deployment

The Things Stack Cloud

The Things Stack Version

3.32.1

Client Name and Version

No response

Other Information

No response

Proposed Fix

	Pagination     struct {
		DefaultLimit int64 `name:"default-limit" description:"The default limit applied to paginated requests if not specified"`
	} `name:"pagination" description:"Pagination settings"`

Contributing

  • I can help by doing more research.
  • I can help by implementing a fix after the proposal above is approved.
  • I can help by testing the fix before it's released.

Validation

Code of Conduct

@KrishnaIyer KrishnaIyer added the c/identity server This is related to the Identity Server label Oct 8, 2024
@KrishnaIyer KrishnaIyer added this to the v3.32.2 milestone Oct 8, 2024
@KrishnaIyer KrishnaIyer added the bug Something isn't working label Oct 8, 2024
@github-actions github-actions bot added the needs/triage We still need to triage this label Oct 8, 2024
@KrishnaIyer KrishnaIyer removed the needs/triage We still need to triage this label Oct 8, 2024
@KrishnaIyer KrishnaIyer added the needs/testing This needs to be tested on staging label Oct 24, 2024
@KrishnaIyer
Copy link
Member Author

This is tested and being rolled out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c/identity server This is related to the Identity Server needs/testing This needs to be tested on staging
Projects
None yet
Development

No branches or pull requests

2 participants