Apply a default pagination on IS List RPCs if not provided in the request #7327
Labels
bug
Something isn't working
c/identity server
This is related to the Identity Server
needs/testing
This needs to be tested on staging
Milestone
Summary
Apply a default pagination on IS List RPCs if not provided in the request.
Steps to Reproduce
Limit
field of the request.Current Result
Currently
limit
value of0
returns all entries.Expected Result
We should use a default value and use that when the limit in the request is not set.
Relevant Logs
No response
URL
No response
Deployment
The Things Stack Cloud
The Things Stack Version
3.32.1
Client Name and Version
No response
Other Information
No response
Proposed Fix
10
: https://github.com/TheThingsNetwork/lorawan-stack/blob/v3.32/cmd/internal/shared/identityserver/config.go#L28WithPagination
, use this default value ifreq.Limit
is not set. https://github.com/TheThingsNetwork/lorawan-stack/blob/v3.32/pkg/identityserver/store/pagination.go#L36Contributing
Validation
Code of Conduct
The text was updated successfully, but these errors were encountered: