Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some few issues and sigma2 >= sigma1 assert error #6

Open
Shell64 opened this issue Nov 18, 2016 · 1 comment
Open

Some few issues and sigma2 >= sigma1 assert error #6

Shell64 opened this issue Nov 18, 2016 · 1 comment

Comments

@Shell64
Copy link

Shell64 commented Nov 18, 2016

de_dust2.zip

Hello again, thank you for fixing the compilation errors. I've been testing it and found some issues:

Coherence:

The thekla atlas example tells it "Produced debug_packer_final.tga" but it does not by default because DEBUG_OUTPUT is 0

#define DEBUG_OUTPUT 0

Changing DEBUG_OUTPUT to 1 will make a new compilation error:

#include "nvimage/ImageIO.h"

It is including "nvimage/ImageIO.h" but there's no such file. A fix is to:

//outputDebugImage("debug_packer_final.tga", m_debug_bitmap, w, h);

Comment the include line, line 843 and uncomment line 842.

sigma2 >= sigma1

I have attached an object file in this issue, this model will produce sigma2 >= sigma1 assert error, it does come from:

The problem is that t1 s1 and t2 s2 are IND0 (indefinite).. I was trying to track where it gets indefinite, it comes from this:

alpha = delta_new / dot(p, q);

There's a division by 0 happening in there that does that. I did try override alpha to -0.000001f if it's 0.0f so it could bypass this sigma assert, but it does explode the UVs (the triangles spikes everywhere in texture coordinates). There's also an overload of the same function and equation happening a little above from this one but I'm not sure if it's being used.

I also did build an obj validator to make sure it doesn't have null indices etc, everything is fine, every program loads the model fine.

Sorry if I misspelled something, English is not my main language and my C/C++ knowledge is also very limited.

@Shell64
Copy link
Author

Shell64 commented Nov 18, 2016

face1
face2

This is the face that is causing the assert error, I don't know the vertex order correctly but the vertices are:

v 27.643236 86.478470 -6.248400
v 27.348259 85.831360 -6.248400
v 27.348183 85.831421 -2.565400

*I might be wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant