Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve backward reversibility #16

Open
Yivan opened this issue Nov 22, 2016 · 2 comments
Open

Improve backward reversibility #16

Yivan opened this issue Nov 22, 2016 · 2 comments

Comments

@Yivan
Copy link

Yivan commented Nov 22, 2016

Hello,

It is a very nice plugins adding interresting way to select object relation.
The Dynamic DropDown, Itemselector and Superbox Select are backward reversible as they extend href and multihref. This is a must have feature as it garanty that data will be always here and exploitable even if plugin is not more maintened. It try changing back their type to href/multihref (in the class panel editor) and datas are kept. So good : )

Only the Dynamic DropDown (multiselect) works not the same and extend multiselect. It meaans go back to native pimcore type will be harder...
This issue is about making Dynamic DropDown (multiselect) extend multihref instead, so there is more coherence between those 4 new datatypes and all could be reverted as needed by just changing the type back to href/multhref.

@Yivan Yivan changed the title Improve backward compatibility Improve backward reversibility Nov 22, 2016
@ThomasKeil
Copy link
Owner

This is indeed a valid issue - but changing the datatype will break the compability with existing installations.

Suggestions?

@Yivan
Copy link
Author

Yivan commented Jan 17, 2017

Yes you are right, it will break backward compatibility.

There are two ways I think of:

1- The hard way: making a script update wich will take care of making the changes in database (with the API), so multiselect data are changed to multihref data, and datas are migrated.

2- More easy: rename it to Dynamic DropDown (multiselect - DEPRECATED) (just visually in the class editor), and create a new type Dynamic DropDown (multiselect) which extend multihref. So new user can use this one and keep data if they revert this field to the classic multihref native Pimcore.

I will go for the second one, and in some time/few version, you could remove the deprecated one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants