Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipient organisation type chart does not recognise Church codes as an org type #244

Open
KDuerden opened this issue Nov 28, 2024 · 10 comments
Assignees
Labels
bug Something isn't working

Comments

@KDuerden
Copy link

This funder has published 637 grants. 433 of these use newly adopted org ID type, GB-COE - https://org-id.guide/list/GB-COE

However these do not appear in the chart, and are instead the chart states that they "did not include information to determine recipient organisation type."

image

Data for reference is here:
https://grantvis.threesixtygiving.org/?query=*&default_field=*&sort=_score+desc&fundingOrganization=GB-CHC-1074857

@KDuerden KDuerden added the bug Something isn't working label Nov 28, 2024
@mariongalley
Copy link

Thanks Katherine, that's really helpful. @michaelwood Is there a way to add churches to our list of recognised org types now that the church codes are in org-id.guide?

@michaelwood
Copy link
Member

Those organisation type categories are defined by Find That Charity so need to be added there.

@mariongalley
Copy link

@drkane Can you look into this one on the FTC side please? Happy for the issue to be moved to that repo instead

@drkane
Copy link
Contributor

drkane commented Dec 2, 2024

Not to ping this around different repos but I think this might need to be a change to the datastore.

Specifically this script: https://github.com/ThreeSixtyGiving/datastore/blob/live/datastore/additional_data/sources/load_all_org_data.sh needs to have a line added:

./manage.py load_org_data https://findthatcharity.uk/orgid/source/coe.csv

And then needs to be rerun (can't remember if it's rerun periodically anyway?) - the data should then filter through to grantnav and grantvis. The organisations will be shown as "Church".

@michaelwood
Copy link
Member

Thanks David, great to hear those orgs are available. I'll move this issue to the datastore.

@michaelwood michaelwood transferred this issue from ThreeSixtyGiving/grantvis Dec 3, 2024
@drkane
Copy link
Contributor

drkane commented Dec 4, 2024

I took the opportunity to see if there are any other sources that are missing from the import list. I've set up a dashboard which shows the sources used, how many organisations and when they were last updated.

This seems to suggest there are three missing sources:

  • coe - church codes as discussed above
  • lamysociety - local authorities as maintained by mysociety - this replaces the registers which are now longer updated
  • officeforstudents - UKPRN codes for higher education institutions

There are 4 sources which are deprecated so could probably be removed: lae, lani, las, pla - these are the local authority registers.

The nideptofeducation source has been broken since last year, but is still in theory an active source so I think should be kept.

So the updated list would look like:

#!/bin/bash
# Load all the different types of org data from Find That Charity.

./manage.py load_org_data https://findthatcharity.uk/orgid/source/casc.csv
./manage.py load_org_data https://findthatcharity.uk/orgid/source/ccew.csv
./manage.py load_org_data https://findthatcharity.uk/orgid/source/ccni.csv
./manage.py load_org_data https://findthatcharity.uk/orgid/source/oscr.csv
./manage.py load_org_data https://findthatcharity.uk/orgid/source/companies.csv
./manage.py load_org_data https://findthatcharity.uk/orgid/source/mutuals.csv
./manage.py load_org_data https://findthatcharity.uk/orgid/source/gor.csv
./manage.py load_org_data https://findthatcharity.uk/orgid/source/ror.csv
./manage.py load_org_data https://findthatcharity.uk/orgid/source/hesa.csv
./manage.py load_org_data https://findthatcharity.uk/orgid/source/coe.csv
./manage.py load_org_data https://findthatcharity.uk/orgid/source/lamysociety.csv
./manage.py load_org_data https://findthatcharity.uk/orgid/source/officeforstudents.csv
./manage.py load_org_data https://findthatcharity.uk/orgid/source/nhsods-epraccur.csv
./manage.py load_org_data https://findthatcharity.uk/orgid/source/nhsods-etr.csv
./manage.py load_org_data https://findthatcharity.uk/orgid/source/nhsods-ensa.csv
./manage.py load_org_data https://findthatcharity.uk/orgid/source/nhsods-eccg.csv
./manage.py load_org_data https://findthatcharity.uk/orgid/source/nhsods-ecsu.csv
./manage.py load_org_data https://findthatcharity.uk/orgid/source/nhsods-espha.csv
./manage.py load_org_data https://findthatcharity.uk/orgid/source/nhsods-wlhb.csv
./manage.py load_org_data https://findthatcharity.uk/orgid/source/nhsods-ect.csv
./manage.py load_org_data https://findthatcharity.uk/orgid/source/rsl.csv
./manage.py load_org_data https://findthatcharity.uk/orgid/source/gias.csv schools_gias
./manage.py load_org_data https://findthatcharity.uk/orgid/source/nideptofeducation.csv schools_ni
./manage.py load_org_data https://findthatcharity.uk/orgid/source/schoolsscotland.csv schools_scotland
./manage.py load_org_data https://findthatcharity.uk/orgid/source/walesschools.csv schools_wales

@KDuerden
Copy link
Author

KDuerden commented Dec 6, 2024

Thanks for sorting this out.

There are 4 sources which are deprecated so could probably be removed: lae, lani, las, pla - these are the local authority registers.

Can we please discuss this before actioning any depreciation or removal. We are still recommending using these, and the new Mysociety org ID prefix/type hasn't been submitted to org-id.guide yet so we should agree next steps and put alternatives in place before removing the existing org ID types from our systems.

@drkane
Copy link
Contributor

drkane commented Dec 6, 2024

Thanks Katherine - that's a good point. I'm not planning to remove them from find-that-charity, and they wouldn't be removed from the datastore I don't think (just no longer updated) - but it's probably a good idea to keep them in this list anyway in case we ever needed to rebuild the list from scratch to make sure they're in there.

@KDuerden
Copy link
Author

KDuerden commented Dec 6, 2024

thanks for clarifying that it relates to the updates, rather than the org IDs themselves - all understood!

@mariongalley mariongalley self-assigned this Dec 19, 2024
@mariongalley
Copy link

We need to look at the scale of legitimate org ids that aren't getting assigned org types - it looks like this includes Companies Limited by Shares, but also there seems to be a bunch of other company and charity and other types of IDs not getting mapped to an org type (~60k records for 2020-23 data)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants